libsysio-commit

[Libsysio-commit] HEAD: libsysio/tests test_list.c

[Lee W. <lw...@us...>]

Update of /cvsroot/libsysio/libsysio/tests
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv32223/tests

Modified Files:
	test_list.c 
Log Message:


Cleaned out all the pointer arithmetic utilizing void pointers. No longer
build the empty statvfs{64} modules. All in an attempt to make the code
C99 compliant.


Index: test_list.c
===================================================================
RCS file: /cvsroot/libsysio/libsysio/tests/test_list.c,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -w -b -B -p -r1.7 -r1.8
--- test_list.c	14 Feb 2004 19:43:00 -0000	1.7
+++ test_list.c	24 Feb 2004 14:58:26 -0000	1.8
@@ -175,7 +175,7 @@ listit(const char *path)
 				      (unsigned long long )dp->d_ino,
 				      (int )dp->d_type);
 			cc -= dp->d_reclen;
-			dp = (void *)dp + dp->d_reclen;
+			dp = (struct dirent *)((char *)dp + dp->d_reclen);
 		}
 		if (!base)
 			break;

[Libsysio-commit] HEAD: libsysio/tests test_list.c

[Lee W. <lw...@us...>]

Update of /cvsroot/libsysio/libsysio/tests
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv29988

Modified Files:
	test_list.c 
Log Message:


Fixed to reflect the new, proper, operation of getdirentries. Previously,
we were counting on the base pointer to getdirentries to return to zero
at EOF. That was erroneous. The only EOF check is the number of bytes
returned going to zero.

Aslo, fixed a bug. Hadn't wrapped the close.



Index: test_list.c
===================================================================
RCS file: /cvsroot/libsysio/libsysio/tests/test_list.c,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -w -b -B -p -r1.10 -r1.11
--- test_list.c	4 Feb 2005 00:29:26 -0000	1.10
+++ test_list.c	4 Aug 2005 19:48:49 -0000	1.11
@@ -166,7 +166,6 @@ listit(const char *path)
 		goto out;
 	}
 
-	base = 0;
 	while ((cc = SYSIO_INTERFACE_NAME(getdirentries)(fd,
 							 (char *)buf,
 							 n,
@@ -180,8 +179,6 @@ listit(const char *path)
 			cc -= dp->d_reclen;
 			dp = (struct dirent *)((char *)dp + dp->d_reclen);
 		}
-		if (!base)
-			break;
 	}
 
 out:
@@ -192,7 +189,7 @@ out:
 	{
 		int	oerrno = errno;
 
-		if (close(fd) != 0) {
+		if (SYSIO_INTERFACE_NAME(close)(fd) != 0) {
 			perror(path);
 			if (cc < 0)
 				errno = oerrno;

[Libsysio-commit] HEAD: libsysio/tests test_list.c

[Ruth K. <rk...@us...>]

Update of /cvsroot/libsysio/libsysio/tests
In directory sc8-pr-cvs6.sourceforge.net:/tmp/cvs-serv22463/tests

Modified Files:
	test_list.c 
Log Message:
2 uninitialized vars noticed by valgrind

Index: test_list.c
===================================================================
RCS file: /cvsroot/libsysio/libsysio/tests/test_list.c,v
retrieving revision 1.13
retrieving revision 1.14
diff -u -w -b -B -p -r1.13 -r1.14
--- test_list.c	28 Mar 2007 21:27:12 -0000	1.13
+++ test_list.c	16 Nov 2007 20:58:08 -0000	1.14
@@ -148,7 +148,7 @@ listit(const char *path)
 	int	fd;
 	size_t	n;
 	struct dirent *buf, *dp;
-	off_t	base;
+	off_t	base = 0;
 	ssize_t	cc;
 
 	fd = SYSIO_INTERFACE_NAME(open)(path, O_RDONLY);