libsysio-commit

[Libsysio-commit] RELEASE_1_3: libsysio/src rw.c

[Lee W. <lw...@us...>]

Update of /cvsroot/libsysio/libsysio/src
In directory sc8-pr-cvs6.sourceforge.net:/tmp/cvs-serv28083

Modified Files:
      Tag: RELEASE_1_3
	rw.c 
Log Message:


>From Bob Glossman (bo...@cr...), during regression testing:

Error number from pwrite is negative.

Doh! Worse, _do_ipiov should be using the negated return code from
_sysio_sum_iovec and not it's own. Fixed.



Index: rw.c
===================================================================
RCS file: /cvsroot/libsysio/libsysio/src/rw.c,v
retrieving revision 1.22
retrieving revision 1.22.2.1
diff -u -w -b -B -p -r1.22 -r1.22.2.1
--- rw.c	2 Jul 2007 18:58:17 -0000	1.22
+++ rw.c	9 Oct 2007 17:13:43 -0000	1.22.2.1
@@ -582,7 +582,7 @@ _do_ipiov(int fd,
 
 	cc = _sysio_sum_iovec(iov, count);
 	if (cc < 0) {
-		errno = -EINVAL;
+		errno = (int )-cc;
 		return IOID_FAIL;
 	}
 	xtv = malloc(sizeof(struct intnl_xtvec));

[Libsysio-commit] RELEASE_1_3: libsysio/src rw.c

[Lee W. <lw...@us...>]

Update of /cvsroot/libsysio/libsysio/src
In directory sc8-pr-cvs6.sourceforge.net:/tmp/cvs-serv2098

Modified Files:
      Tag: RELEASE_1_3
	rw.c 
Log Message:


>From Bob Glossman (bo...@cr...) found during regression testing:

pwrite returns -1 [EINVAL]

The _do_ipio routine was sending the number of bytes in the buffer to
the _do_ipiov, helper, routine to be used as the iovec count.
Changed to one.  Fixed.



Index: rw.c
===================================================================
RCS file: /cvsroot/libsysio/libsysio/src/rw.c,v
retrieving revision 1.22.2.1
retrieving revision 1.22.2.2
diff -u -w -b -B -p -r1.22.2.1 -r1.22.2.2
--- rw.c	9 Oct 2007 17:13:43 -0000	1.22.2.1
+++ rw.c	9 Oct 2007 17:21:41 -0000	1.22.2.2
@@ -720,7 +720,7 @@ _do_ipio(int fd,
 		return IOID_FAIL;
 	iov->iov_base = buf;
 	iov->iov_len = count;
-	ioid = _do_ipiov(fd, f, iov, count, free_arg, offset, NULL);
+	ioid = _do_ipiov(fd, f, iov, 1, free_arg, offset, NULL);
 	if (ioid == IOID_FAIL)
 		free(iov);
 	return ioid;