Re: [Libsigcx-main] Event handling fixes

[Steven B. <sw...@uc...>]

[2 week no response resend]


Andreas Rottmann wrote:
> Steven Brown <sw...@uc...> writes:
> 
>>[2 week no response resend]
>>
> Sorry, been busy lately, day job and all.

No prob., mail often goes into the void so I just poll patches every 2
weeks.

> I have one stylistic issue with the patch: method names should not be
> javaStyle, but gtkmm_style (lowercase, underscores).

D'oh, I try and match style but I apparently missed a couple things.  Fixed.

> Also, it would be *great* if you could set up an archive and store
> the changesets there, easing work for both you and me.

I believe I've now set one up (tagged from yours) that contains the
modified version of this patch to fix a couple style similarity issues -
it obsoletes the one in email.  This is my first stab at arch, so
hopefully everything went ok.

tla register-archive "http://wiisard.org/~swbrown/{archives}/2005-fixes"
tla get sw...@uc...--2005-fixes/libsigcx--events--0.1 libsigcx-events

One other thing, in your arch tree, scripts/mkinstalldirs was generated
(Sarge) via autogen.sh, but isn't known to the tree.  I'm not sure of
the right mechanism to tell arch it's junk, but it should be ignored
somehow.

swbrown@wiisard:~/src/libsigcx-events$ tla commit
These apparent source files lack inventory ids:

scripts/mkinstalldirs


commit: commit aborted