Re: [Libsigcx-main] Event handling fixes

[Andreas R. <a.r...@gm...>]

Steven Brown <sw...@uc...> writes:

> [2 week no response resend]
>
Sorry, been busy lately, day job and all.

>
> There were some errors with how libsigcx handles events - the attached
> patch fixes them.  Here's the changelog entry from the attached patch:
>
>           * sigcx/dispatch.cc, sigcx/dispatch.h: Fix iterator corruption
>           and calling removed handlers when removing event handlers from
>           event handlers, and fix not select()ing on the first pass on
>           file event handlers added from event handlers on the same pass.
>
> With these patches and the current arch tree, my stuff is working quite
> well.  It'd be great if a 0.6.5 could be rolled from the arch tree after
> this is applied.  If it's a time issue for you, I could see about
> rolling one for you.
>
I accidentially already rolled an 0.6.5 tarball in a rush to fix a
Debian FTBFS; I'll do a 0.6.7 after incorporating your patches.

> 2005-07-08  Steven Brown  <sw...@uc...>
>
> 	* sigcx/dispatch.cc, sigcx/dispatch.h: Fix iterator corruption and
> 	calling removed handlers when removing event handlers from event
> 	handlers, and fix not select()ing on the first pass on file event
> 	handlers added from event handlers on the same pass.
>
>
I have one stylistic issue with the patch: method names should not be
javaStyle, but gtkmm_style (lowercase, underscores). Also, it would be
*great* if you could set up an archive and store the changesets
there, easing work for both you and me.

Cheers, Rotty
-- 
Andreas Rottmann         | Rotty@ICQ      | 118634484@ICQ | a.r...@gm...
http://yi.org/rotty      | GnuPG Key: http://yi.org/rotty/gpg.asc
Fingerprint              | DFB4 4EB4 78A4 5EEE 6219  F228 F92F CFC5 01FD 5B62
v2sw7MYChw5pr5OFma7u7Lw2m5g/l7Di6e6t5BSb7en6g3/5HZa2Xs6MSr1/2p7 hackerkey.com

Beware of bugs in the above code; I have only proved it correct,
not tried it.  -- Donald E. Knuth