Thread: [Libsigcx-main] Event handling fixes
Status: Beta
Brought to you by:
rottmann
Menu
▾
▴
libsigcx-main
|
From: Steven B. <sw...@uc...> - 2005-07-13 03:06:48
Attachments:
libsigcx-200507081-event-fixes-swb.patch
|
There were some errors with how libsigcx handles events - the attached
patch fixes them. Here's the changelog entry from the attached patch:
* sigcx/dispatch.cc, sigcx/dispatch.h: Fix iterator corruption
and calling removed handlers when removing event handlers from
event handlers, and fix not select()ing on the first pass on
file event handlers added from event handlers on the same pass.
With these patches and the current arch tree, my stuff is working quite
well. It'd be great if a 0.6.5 could be rolled from the arch tree after
this is applied. If it's a time issue for you, I could see about
rolling one for you.
|
|
From: Steven B. <sw...@uc...> - 2005-07-30 08:13:47
Attachments:
libsigcx-200507081-event-fixes-swb.patch
|
[2 week no response resend]
There were some errors with how libsigcx handles events - the attached
patch fixes them. Here's the changelog entry from the attached patch:
* sigcx/dispatch.cc, sigcx/dispatch.h: Fix iterator corruption
and calling removed handlers when removing event handlers from
event handlers, and fix not select()ing on the first pass on
file event handlers added from event handlers on the same pass.
With these patches and the current arch tree, my stuff is working quite
well. It'd be great if a 0.6.5 could be rolled from the arch tree after
this is applied. If it's a time issue for you, I could see about
rolling one for you.
|
|
From: Andreas R. <a.r...@gm...> - 2005-08-01 18:05:03
|
Steven Brown <sw...@uc...> writes: > [2 week no response resend] > Sorry, been busy lately, day job and all. > > There were some errors with how libsigcx handles events - the attached > patch fixes them. Here's the changelog entry from the attached patch: > > * sigcx/dispatch.cc, sigcx/dispatch.h: Fix iterator corruption > and calling removed handlers when removing event handlers from > event handlers, and fix not select()ing on the first pass on > file event handlers added from event handlers on the same pass. > > With these patches and the current arch tree, my stuff is working quite > well. It'd be great if a 0.6.5 could be rolled from the arch tree after > this is applied. If it's a time issue for you, I could see about > rolling one for you. > I accidentially already rolled an 0.6.5 tarball in a rush to fix a Debian FTBFS; I'll do a 0.6.7 after incorporating your patches. > 2005-07-08 Steven Brown <sw...@uc...> > > * sigcx/dispatch.cc, sigcx/dispatch.h: Fix iterator corruption and > calling removed handlers when removing event handlers from event > handlers, and fix not select()ing on the first pass on file event > handlers added from event handlers on the same pass. > > I have one stylistic issue with the patch: method names should not be javaStyle, but gtkmm_style (lowercase, underscores). Also, it would be *great* if you could set up an archive and store the changesets there, easing work for both you and me. Cheers, Rotty -- Andreas Rottmann | Rotty@ICQ | 118634484@ICQ | a.r...@gm... http://yi.org/rotty | GnuPG Key: http://yi.org/rotty/gpg.asc Fingerprint | DFB4 4EB4 78A4 5EEE 6219 F228 F92F CFC5 01FD 5B62 v2sw7MYChw5pr5OFma7u7Lw2m5g/l7Di6e6t5BSb7en6g3/5HZa2Xs6MSr1/2p7 hackerkey.com Beware of bugs in the above code; I have only proved it correct, not tried it. -- Donald E. Knuth |
|
From: Steven B. <sw...@uc...> - 2005-08-02 07:02:04
|
Andreas Rottmann wrote: > Steven Brown <sw...@uc...> writes: > >>[2 week no response resend] >> > Sorry, been busy lately, day job and all. No prob., mail often goes into the void so I just poll patches every 2 weeks. > I have one stylistic issue with the patch: method names should not be > javaStyle, but gtkmm_style (lowercase, underscores). D'oh, I try and match style but I apparently missed a couple things. Fixed. > Also, it would be *great* if you could set up an archive and store > the changesets there, easing work for both you and me. I believe I've now set one up (tagged from yours) that contains the modified version of this patch to fix a couple style similarity issues - it obsoletes the one in email. This is my first stab at arch, so hopefully everything went ok. tla register-archive "http://wiisard.org/~swbrown/{archives}/2005-fixes" tla get sw...@uc...--2005-fixes/libsigcx--events--0.1 libsigcx-events One other thing, in your arch tree, scripts/mkinstalldirs was generated (Sarge) via autogen.sh, but isn't known to the tree. I'm not sure of the right mechanism to tell arch it's junk, but it should be ignored somehow. swbrown@wiisard:~/src/libsigcx-events$ tla commit These apparent source files lack inventory ids: scripts/mkinstalldirs commit: commit aborted |
|
From: Steven B. <sw...@uc...> - 2005-08-23 20:35:31
|
[2 week no response resend] Andreas Rottmann wrote: > Steven Brown <sw...@uc...> writes: > >>[2 week no response resend] >> > Sorry, been busy lately, day job and all. No prob., mail often goes into the void so I just poll patches every 2 weeks. > I have one stylistic issue with the patch: method names should not be > javaStyle, but gtkmm_style (lowercase, underscores). D'oh, I try and match style but I apparently missed a couple things. Fixed. > Also, it would be *great* if you could set up an archive and store > the changesets there, easing work for both you and me. I believe I've now set one up (tagged from yours) that contains the modified version of this patch to fix a couple style similarity issues - it obsoletes the one in email. This is my first stab at arch, so hopefully everything went ok. tla register-archive "http://wiisard.org/~swbrown/{archives}/2005-fixes" tla get sw...@uc...--2005-fixes/libsigcx--events--0.1 libsigcx-events One other thing, in your arch tree, scripts/mkinstalldirs was generated (Sarge) via autogen.sh, but isn't known to the tree. I'm not sure of the right mechanism to tell arch it's junk, but it should be ignored somehow. swbrown@wiisard:~/src/libsigcx-events$ tla commit These apparent source files lack inventory ids: scripts/mkinstalldirs commit: commit aborted |
|
From: Steven B. <sw...@uc...> - 2005-10-06 21:03:12
|
[no response resend] Steven Brown wrote: > [2 week no response resend] > > > Andreas Rottmann wrote: > >>Steven Brown <sw...@uc...> writes: >> >> >>>[2 week no response resend] >>> >> >>Sorry, been busy lately, day job and all. > > > No prob., mail often goes into the void so I just poll patches every 2 > weeks. > > >>I have one stylistic issue with the patch: method names should not be >>javaStyle, but gtkmm_style (lowercase, underscores). > > > D'oh, I try and match style but I apparently missed a couple things. Fixed. > > >>Also, it would be *great* if you could set up an archive and store >>the changesets there, easing work for both you and me. > > > I believe I've now set one up (tagged from yours) that contains the > modified version of this patch to fix a couple style similarity issues - > it obsoletes the one in email. This is my first stab at arch, so > hopefully everything went ok. > > tla register-archive "http://wiisard.org/~swbrown/{archives}/2005-fixes" > tla get sw...@uc...--2005-fixes/libsigcx--events--0.1 libsigcx-events > > One other thing, in your arch tree, scripts/mkinstalldirs was generated > (Sarge) via autogen.sh, but isn't known to the tree. I'm not sure of > the right mechanism to tell arch it's junk, but it should be ignored > somehow. > > swbrown@wiisard:~/src/libsigcx-events$ tla commit > These apparent source files lack inventory ids: > > scripts/mkinstalldirs > > > commit: commit aborted > > > > ------------------------------------------------------- > SF.Net email is Sponsored by the Better Software Conference & EXPO > September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices > Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA > Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf > _______________________________________________ > Libsigcx-main mailing list > Lib...@li... > https://lists.sourceforge.net/lists/listinfo/libsigcx-main |
|
From: Steven B. <sw...@uc...> - 2005-12-17 16:18:11
|
It's been many months since I submitted these fixes (7/12/2005), and many mails that have gone ignored. Without these fixes, libsigcx has critical bugs. Please commit them. Steven Brown wrote: > [no response resend] > > Steven Brown wrote: >> [2 week no response resend] >> >> >> Andreas Rottmann wrote: >> >>> Steven Brown <sw...@uc...> writes: >>> >>> >>>> [2 week no response resend] >>>> >>> >>> Sorry, been busy lately, day job and all. >> >> >> No prob., mail often goes into the void so I just poll patches every 2 >> weeks. >> >> >>> I have one stylistic issue with the patch: method names should not be >>> javaStyle, but gtkmm_style (lowercase, underscores). >> >> >> D'oh, I try and match style but I apparently missed a couple things. >> Fixed. >> >> >>> Also, it would be *great* if you could set up an archive and store >>> the changesets there, easing work for both you and me. >> >> >> I believe I've now set one up (tagged from yours) that contains the >> modified version of this patch to fix a couple style similarity issues - >> it obsoletes the one in email. This is my first stab at arch, so >> hopefully everything went ok. >> >> tla register-archive "http://wiisard.org/~swbrown/{archives}/2005-fixes" >> tla get sw...@uc...--2005-fixes/libsigcx--events--0.1 >> libsigcx-events >> >> One other thing, in your arch tree, scripts/mkinstalldirs was generated >> (Sarge) via autogen.sh, but isn't known to the tree. I'm not sure of >> the right mechanism to tell arch it's junk, but it should be ignored >> somehow. >> >> swbrown@wiisard:~/src/libsigcx-events$ tla commit >> These apparent source files lack inventory ids: >> >> scripts/mkinstalldirs >> >> >> commit: commit aborted >> >> >> >> ------------------------------------------------------- >> SF.Net email is Sponsored by the Better Software Conference & EXPO >> September 19-22, 2005 * San Francisco, CA * Development Lifecycle >> Practices >> Agile & Plan-Driven Development * Managing Projects & Teams * Testing >> & QA >> Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf >> _______________________________________________ >> Libsigcx-main mailing list >> Lib...@li... >> https://lists.sourceforge.net/lists/listinfo/libsigcx-main > > |
|
From: Steven B. <sw...@uc...> - 2006-02-15 03:13:30
|
[no response resend - 2/14/2006] It's been many months since I submitted these fixes (7/12/2005), and many mails that have gone ignored. Without these fixes, libsigcx has critical bugs. Please commit them. Steven Brown wrote: > [no response resend] > > Steven Brown wrote: >> [2 week no response resend] >> >> >> Andreas Rottmann wrote: >> >>> Steven Brown <sw...@uc...> writes: >>> >>> >>>> [2 week no response resend] >>>> >>> >>> Sorry, been busy lately, day job and all. >> >> >> No prob., mail often goes into the void so I just poll patches every 2 >> weeks. >> >> >>> I have one stylistic issue with the patch: method names should not be >>> javaStyle, but gtkmm_style (lowercase, underscores). >> >> >> D'oh, I try and match style but I apparently missed a couple things. >> Fixed. >> >> >>> Also, it would be *great* if you could set up an archive and store >>> the changesets there, easing work for both you and me. >> >> >> I believe I've now set one up (tagged from yours) that contains the >> modified version of this patch to fix a couple style similarity issues - >> it obsoletes the one in email. This is my first stab at arch, so >> hopefully everything went ok. >> >> tla register-archive "http://wiisard.org/~swbrown/{archives}/2005-fixes" >> tla get sw...@uc...--2005-fixes/libsigcx--events--0.1 >> libsigcx-events >> >> One other thing, in your arch tree, scripts/mkinstalldirs was generated >> (Sarge) via autogen.sh, but isn't known to the tree. I'm not sure of >> the right mechanism to tell arch it's junk, but it should be ignored >> somehow. >> >> swbrown@wiisard:~/src/libsigcx-events$ tla commit >> These apparent source files lack inventory ids: >> >> scripts/mkinstalldirs >> >> >> commit: commit aborted >> >> >> >> ------------------------------------------------------- >> SF.Net email is Sponsored by the Better Software Conference & EXPO >> September 19-22, 2005 * San Francisco, CA * Development Lifecycle >> Practices >> Agile & Plan-Driven Development * Managing Projects & Teams * Testing >> & QA >> Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf >> _______________________________________________ >> Libsigcx-main mailing list >> Lib...@li... >> https://lists.sourceforge.net/lists/listinfo/libsigcx-main > > |
|
From: Steven B. <sw...@uc...> - 2006-06-06 01:54:15
|
[no response resend - 6/05/2006] I recently made a change to correct a spurious fd bug in dispatch.cc. Patches are still in the arch tree, waiting to be merged. Steven Brown wrote: > [no response resend - 2/14/2006] > > It's been many months since I submitted these fixes (7/12/2005), and > many mails that have gone ignored. Without these fixes, libsigcx has > critical bugs. Please commit them. > > Steven Brown wrote: >> [no response resend] >> >> Steven Brown wrote: >>> [2 week no response resend] >>> >>> >>> Andreas Rottmann wrote: >>> >>>> Steven Brown <sw...@uc...> writes: >>>> >>>> >>>>> [2 week no response resend] >>>>> >>>> >>>> Sorry, been busy lately, day job and all. >>> >>> >>> No prob., mail often goes into the void so I just poll patches every 2 >>> weeks. >>> >>> >>>> I have one stylistic issue with the patch: method names should not be >>>> javaStyle, but gtkmm_style (lowercase, underscores). >>> >>> >>> D'oh, I try and match style but I apparently missed a couple things. >>> Fixed. >>> >>> >>>> Also, it would be *great* if you could set up an archive and store >>>> the changesets there, easing work for both you and me. >>> >>> >>> I believe I've now set one up (tagged from yours) that contains the >>> modified version of this patch to fix a couple style similarity issues - >>> it obsoletes the one in email. This is my first stab at arch, so >>> hopefully everything went ok. >>> >>> tla register-archive "http://wiisard.org/~swbrown/{archives}/2005-fixes" >>> tla get sw...@uc...--2005-fixes/libsigcx--events--0.1 >>> libsigcx-events >>> >>> One other thing, in your arch tree, scripts/mkinstalldirs was generated >>> (Sarge) via autogen.sh, but isn't known to the tree. I'm not sure of >>> the right mechanism to tell arch it's junk, but it should be ignored >>> somehow. >>> >>> swbrown@wiisard:~/src/libsigcx-events$ tla commit >>> These apparent source files lack inventory ids: >>> >>> scripts/mkinstalldirs >>> >>> >>> commit: commit aborted >>> >>> >>> >>> ------------------------------------------------------- >>> SF.Net email is Sponsored by the Better Software Conference & EXPO >>> September 19-22, 2005 * San Francisco, CA * Development Lifecycle >>> Practices >>> Agile & Plan-Driven Development * Managing Projects & Teams * Testing >>> & QA >>> Security * Process Improvement & Measurement * >>> http://www.sqe.com/bsce5sf >>> _______________________________________________ >>> Libsigcx-main mailing list >>> Lib...@li... >>> https://lists.sourceforge.net/lists/listinfo/libsigcx-main >> >> > > > |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X