Menu

#15 please enable unit tests

open
nobody
None
5
2015-04-18
2015-03-12
No

this patch makes the tests build on debian (I'm currently packaging the latest snapshot)

I don't run them, but at least I can check if a sample program builds correctly

--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -1,6 +1,6 @@
AM_CXXFLAGS = -Weffc++

-#noinst_PROGRAMS = unit_tests
+noinst_PROGRAMS = unit_tests

lib_LTLIBRARIES = libserial.la

@@ -9,7 +9,7 @@ include_HEADERS = SerialStreamBuf.h SerialStream.h SerialPort.h
libserial_la_SOURCES = SerialStreamBuf.cc SerialStreamBuf.h SerialStream.cc \
SerialStream.h SerialPort.cpp SerialPort.h PosixSignalDispatcher.cpp

-#unit_tests_SOURCES = unit_tests.cpp
-#unit_tests_LDADD = libserial.la -lboost_unit_test_framework-mt
+unit_tests_SOURCES = unit_tests.cpp
+unit_tests_LDADD = libserial.la -lboost_unit_test_framework

noinst_HEADERS = PosixSignalDispatcher.h PosixSignalHandler.h

Discussion

  • Gianfranco Costamagna

    Also please fix your libserial.pc.in file

    --- libserial-0.6.0~rc1+svn114.orig/libserial.pc.in
    +++ libserial-0.6.0~rc1+svn114/libserial.pc.in
    @@ -1,7 +1,7 @@
    prefix=@prefix@
    -exec_prefix=${prefix}
    -libdir=${exec_prefix}/lib
    -includedir=${prefix}/include
    +exec_prefix=@exec_prefix@
    +libdir=@libdir@
    +includedir=@includedir@

    Name: libserial
    Description: C++ Serial port library

    in multiarch location your actual file doesn't work e.g. /usr/lib/x

     
  • Crayzee Wulf

    Crayzee Wulf - 2015-04-03

    Thanks for the feedback. I will update both of these along with ability to query the low-level file descriptor.

     
  • Gianfranco Costamagna

    Hi Crayzee, thanks for the low level file descriptor patch! I'll test it shortly, and thanks for the test suite work.

    Just a side note, there is also a libserial.pc patch there, don't forget it :p

    (next time I'll probably open three different threads, sorry for that)

     
  • Crayzee Wulf

    Crayzee Wulf - 2015-04-18

    Gianfranco, SVN should have all of these fixes now. Thanks a bunch once again for helping out. Please let me know if you find any (more) mistakes.

     

Log in to post a comment.

MongoDB Logo MongoDB