This requires non-trivial refactoring of code and will delay release. Are there any compelling use cases where empty strings are critical? Currently some test files are failing because a Sequence elements property is set to "". In these cases the Sequence objects seem to contain no data are superfluous.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I think this could be delayed to the next release, but I do think this fix should be done. Again, it comes down to not changing data during a read/write roundtrip. Furthermore, for the examples that have this, it changes a valid model into an invalid one, since the elements field is required in a sequence. So, this is not good either.
Correct me if I’m wrong, is the problem that your code cannot distinguish between an empty string and no string at all? Is it not possible to initialize strings to “null” rather than an empty string? In libSBOLj, we have isSet methods, and they will return true for empty string and false for null string.
This requires non-trivial refactoring of code and will delay release. Are there any compelling use cases where empty strings are critical? Currently some test files are failing because a Sequence elements property is set to "". In these cases the Sequence objects seem to contain no data are superfluous.
View and moderate all "tickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Originally posted by: bbartley
This requires non-trivial refactoring of code and will delay release. Are there any compelling use cases where empty strings are critical? Currently some test files are failing because a Sequence elements property is set to "". In these cases the Sequence objects seem to contain no data are superfluous.
View and moderate all "tickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Originally posted by: cjmyers
I think this could be delayed to the next release, but I do think this fix should be done. Again, it comes down to not changing data during a read/write roundtrip. Furthermore, for the examples that have this, it changes a valid model into an invalid one, since the elements field is required in a sequence. So, this is not good either.
Correct me if I’m wrong, is the problem that your code cannot distinguish between an empty string and no string at all? Is it not possible to initialize strings to “null” rather than an empty string? In libSBOLj, we have isSet methods, and they will return true for empty string and false for null string.