again rdiff cosmetic patch

Status: Beta

Brought to you by: abo, bescoto, mbp, wayned

#6 again rdiff cosmetic patch

Status: closed-accepted

Owner: Donovan Baarda

Labels: Implementation (6)

Priority: 5

Updated: 2003-03-19

Created: 2003-03-07

Creator: Diego Liziero

Private: No

A couple of things left over from my previous patch...

Cosmetic change & 2 possible missing deallocations

(it makes valgrind happier).

rediffed against current cvs (Mar 07 2003)

Discussion

Diego Liziero - 2003-03-07

rdiff cosmetic patch

rdiff_cosmetc_patch.diff

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Donovan Baarda - 2003-03-19

labels: --> Implementation

assigned_to: nobody --> abo
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Donovan Baarda - 2003-03-19

Logged In: YES
user_id=10273

I was not originaly 100% comfortable with this patch... it
adds an rs_file_close to fileutil.h that special-cases
closing stdin or stdout. My first reaction was "this is not
a librsync thing, but an application thing that should only
go into rdiff"... however it seems fileutil.h is just a
corresponding rs_file_open, so this makes sense.

This patch also adds a popt cleanup at the end of rdiff.
Unless anyone complains real soon, I'm going to accept this
patch for inclusion in 0.9.6.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Donovan Baarda - 2003-03-19

status: open --> closed-accepted
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.