Menu

#4 "make check" fails due to apparent error in driver.sh

closed-works-for-me
Testing (2)
4
2004-06-03
2004-01-19
Anonymous
No

librsync v0.9.6, built under Cygwin 1.5.5 on XP Pro SP1

build: ./configure && make all && make check

make check lists two failures: in both cases, rdiff fails
when it cannot find file "--block-size=200". The actual
error is:

sources.test: librsync: ERROR: (rs_file_open) Error
opening "--block-size=200" for read: No such file or direc
tory

Looking at ./testsuite/driver.sh shows that line 153
(invocation of rdiff using "signature" variant) has the
block size option appearing AFTER the "signature"
directive. According to the scant documentation
(basically "rdiff --help" since the manpage, ./doc/rdiff.1,
does not list the options), it appears that all options
should come BEFORE the "signature" directive. I am using
the popt that comes with cygwin (circa sept 2003,
apparently v1.6.4-4), which apparently configure was
able to find (-lpopt).

I "fixed" this by putting the --block-size option before
the signature directive in driver.sh, line 153. Re-
running "make check" then indicates that all (8) tests
now pass. Note that I actually ran "make check", edited
driver.sh, then ran "make check" again and so it is
unclear at this point whether simply running the test
twice "fixed" the problem or whether changing driver.sh
did the trick.

william.rosenkranz@hp.com

(this has nothing to do with HP)

Discussion

  • Donovan Baarda

    Donovan Baarda - 2004-06-03
    • status: open --> closed
     
  • Donovan Baarda

    Donovan Baarda - 2004-06-03

    Logged In: YES
    user_id=10273

    This sounds like a problem with the cygwin version of
    popt... The strange thing here is the popt you are using is
    more recent than the one provided with librsync.

    I have just tested on linux with popt 1.7 and there was no
    problem. I would put this down to a cygwin popt bug. I've
    put this down as "pending", which means if it doesn't get
    confirmed in a couple of weeks, it will automaticly
    transition to "deleted" status.

     
  • Donovan Baarda

    Donovan Baarda - 2004-06-03
    • priority: 5 --> 4
    • assigned_to: nobody --> abo
    • status: closed --> closed-works-for-me
     

Log in to post a comment.