It seems, needs i18n:
"Criterion Types" in CriterionAdminController.getPluralEntityType()
and maybe:
"Criterion Type" in CriterionAdminController.getEntityType()
also needs:
"Machines" in MachineCRUDController.getPluralEntityType()
"Machine" in MachineCRUDController.getEntityType()
"Dedication" in _edition.zul
version - 3.2
Last edit: Sergey 2012-12-17
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
And more:
Strings "Subcontracted by client", "Regular project"
in OrderCRUDController.getProjectType()
and "children","percentage","units","subcontractor","timesheets"
in PredefinedAdvancedTypes
String "Link" should have a separate version of the plural: "Links"
for tab caption in "_edition.zul" (for example)
String: "Defines the time since last saving operation ..."
has i18n call, but has no entry in pot,po files.
All entityNames in table "Entity code sequences" in configuration.zul
Last edit: Sergey 2012-12-20
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Predefined types cannot not be internationalized following the standard procedure as they're records in the database. One option could be internationalize the predefined types during the first setup of LibrePlan however, it's not in our current plans to do it.
I cannot find the string "Link" not sure to which "_edition.zul" file you're referring too.
About the string "Defines the time since last saving operation ..." it's already in the last keys.pot file in master or libreplan-1.3 branch. And it'll be included in the next release 1.3.3.
I've fixed the other 2 issues: OrderCRUDController.getProjectType and configuration.zul.
Thanks for your feedback.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
To be sure certain!
"Label" is used in 6 places (according to po-file)
1: libreplan-webapp/src/main/java/org/libreplan/web/workreports/WorkReportTypeCRUDController.java:838
....
6: libreplan-webapp/src/main/webapp/orders/_edition.zul:48
And only in sixth case requires a "Labels"
The rest did not look.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
This seems an issue with the ZK component we're using. Not sure if installing properly the server locales or the Java locales in the server for that language will help.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
All enums of OrderStatusEnum are not translated,
(in project tooltip in company view - for example)
because method: "org.libreplan.business.i18n.I18nHelper."
only mark strings and do nothing ...
Replacement "state.toString()" on " (state.toString())"
in TaskElementAdapter.getOrderState() helps to solve the problem.
But if you see in code of OrderStatusEnum...
It so good and not used (in the matter of i18n). Why ?
Last edit: Sergey 2012-12-23
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
The reason why a "marker" method is used in the business layer, is that in this layer you don't know the user language. Moreover, the same enum could be used by different users at the same time, causing that it appears only in the language of the first user using it, and the other ones will have that language.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
It seems, needs i18n:
"Criterion Types" in CriterionAdminController.getPluralEntityType()
and maybe:
"Criterion Type" in CriterionAdminController.getEntityType()
also needs:
"Machines" in MachineCRUDController.getPluralEntityType()
"Machine" in MachineCRUDController.getEntityType()
"Dedication" in _edition.zul
version - 3.2
Last edit: Sergey 2012-12-17
Yes, you're right.
Thanks for reporting, I've just fixed the issue: https://github.com/Igalia/libreplan/commit/6695325abb62a82d599212faf0938f1003476fee
And more:
Strings "Subcontracted by client", "Regular project"
in OrderCRUDController.getProjectType()
and "children","percentage","units","subcontractor","timesheets"
in PredefinedAdvancedTypes
String "Link" should have a separate version of the plural: "Links"
for tab caption in "_edition.zul" (for example)
String: "Defines the time since last saving operation ..."
has i18n call, but has no entry in pot,po files.
All entityNames in table "Entity code sequences" in configuration.zul
Last edit: Sergey 2012-12-20
Predefined types cannot not be internationalized following the standard procedure as they're records in the database. One option could be internationalize the predefined types during the first setup of LibrePlan however, it's not in our current plans to do it.
I cannot find the string "Link" not sure to which "_edition.zul" file you're referring too.
About the string "Defines the time since last saving operation ..." it's already in the last keys.pot file in master or libreplan-1.3 branch. And it'll be included in the next release 1.3.3.
I've fixed the other 2 issues: OrderCRUDController.getProjectType and configuration.zul.
Thanks for your feedback.
With "Link" - my mistake (my bug :) - it was "Label" and "Labels"
Thanks, I've just replaced "Label" for "Labels".
To be sure certain!
"Label" is used in 6 places (according to po-file)
1: libreplan-webapp/src/main/java/org/libreplan/web/workreports/WorkReportTypeCRUDController.java:838
....
6: libreplan-webapp/src/main/webapp/orders/_edition.zul:48
And only in sixth case requires a "Labels"
The rest did not look.
Yes, I've only changed it in orders/_edition.zul: https://github.com/Igalia/libreplan/commit/7c46b2b9b514e6c733e06f8fb4cebeae9113926f
Bye,
Rego
What about months names in Company view?
Last edit: Sergey 2012-12-23
This seems an issue with the ZK component we're using. Not sure if installing properly the server locales or the Java locales in the server for that language will help.
All enums of OrderStatusEnum are not translated,
(in project tooltip in company view - for example)
because method: "org.libreplan.business.i18n.I18nHelper."
only mark strings and do nothing ...
Replacement "state.toString()" on " (state.toString())"
in TaskElementAdapter.getOrderState() helps to solve the problem.
But if you see in code of OrderStatusEnum...
It so good and not used (in the matter of i18n). Why ?
Last edit: Sergey 2012-12-23
Thanks for reporting the issue, it's fixed.
The reason why a "marker" method is used in the business layer, is that in this layer you don't know the user language. Moreover, the same enum could be used by different users at the same time, causing that it appears only in the language of the first user using it, and the other ones will have that language.
All strings, that we are talked about above, are absent in keys.pot (v.1.3.3)