Menu
▾
▴
1 Attachments
#556 fillet tool not working like in earlier versions
Fillet tool with trim option activated dose not work as expected when applied on lines drawn by line tools. Trim is not applied and additional lines are added over the drawn lines. Converting them before to polylines solves the problem, but in an earlier version (2.0.7 - that I did use for a longer time), the behavior was different.
Rectangle tool produces a polyline and dose not show this effect.
The very similar tool, Bevel, works like expected with rectangle made from line tool as well as produced by a polyline.
To reproduce the issue:
- draw a rectangle with the line tool (2 points)
- apply fillet with trim on corners
Version: master
SCM Revision: 2.0.9
Compiler: GNU GCC 4.9.1
Qt Version: 5.4.1
Compiled on: Jan 10 2016
Hi,
I can not reproduce this bug with the master branch.
Please note the Draw->Line->Rectangle generate a polyline as results now.
a dxf file is attached.
I confirm the bug using lines.
Fillet works as expected using polylines.
This seems to be caused by wrong (inverted) check for data.trim near the end of RS_Modification::round. Replacing 'if (!isPolyline && !data.trim)' with 'if (!isPolyline && data.trim)' seems to solve both that and the related undo issue.
I've included it with other changes in my pull request on Github, but that version might be a bit more painful to apply, as it has some other changes like adding ability to change existing radius.
I don't know if this is related. The attached Box2.dxf has four arcs arranged as a box with the corners absent. (selecting all gives four items selected) When I fillet one corner (upper left in this case) of the attached Box2.dxf with a radius of 1.1875 (as set in the radius edit box), the two selected arcs are duplicated. Selecting all states seven item selected instead of the five one would expect.
Also, an undo removes the fillet, but does not remove the duplicated arcs. After the one undo, there are no more undos.