#456 Commands "sz" & "Modify - Scale" incorrect

2.0
open-fixed
None
5
2014-03-22
2014-02-27
No

If you type "sz" or go to the command line and type "Modify - Scale" then ENTER, you start a Modify/Move.
I noticed lines 188 and 189 of "rs_commands.cpp" might be incorrect:
mainCommands.insert(tr("sz", "modify - scale"), RS2::ActionModifyMove);
shortCommands.insert(tr("sz"), RS2::ActionModifyMove);

I suppose "ActionModifyScale" should be used.

Discussion

  • Dongxu Li

    Dongxu Li - 2014-02-27

    can you send in a pull request (against master branch), or a patch?

     
    • François D.

      François D. - 2014-03-03

      Sorry, I am absoutely new to this (I created an account on SF just before reporting this problem). I have no idea of what has to be checked (compiled again then run ?) before sending a patch.
      I understand I posted my remark in the wrong group.
      Should I create a new one in the master branch? I've read about moving a ticket, but don't see any mean to do this...
      I also didn't find a kind of tutorial about good practices in using tickets. (Thanks in advance for providing a link if there is any.)

       
  • Dongxu Li

    Dongxu Li - 2014-02-27
    • status: open --> open-accepted
    • assigned_to: Dongxu Li
     
  • Dongxu Li

    Dongxu Li - 2014-03-03

    Hi Francois,

    You can use github.com to send in a repository:

    0, register an account at github.com;
    1, following this link( https://help.github.com/articles/fork-a-repo ) to fork the official repository: https://github.com/LibreCAD/LibreCAD
    2, in your forked repository, browse to and open the file to modify ( librecad/src/cmd/rs_commands.cpp );
    3, use the "Edit" button on the file page to modify the file, and commit your changes using the "Commit changes" button;
    4, follow this howto ( https://help.github.com/articles/creating-a-pull-request ) to send in a pull request to the master branch of official repository ( LibreCAD/LibreCAD ).

    If your changes are more than a few lines, please clone your repository to your local, run qt-creator to do the change, and push the changes, instead of using online editor as described in step 3

     
    Last edit: Dongxu Li 2014-03-03
  • LordOfBikes

    LordOfBikes - 2014-03-22
    • status: open-accepted --> open-fixed
     
  • LordOfBikes

    LordOfBikes - 2014-03-22

    fixed with commit 85b31434

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks