#393 Trim two arcs sometimes deletes the wrong part

2.1
open-accepted
actions (81)
5
2014-07-13
2013-02-22
No

see librecad/src/lib/engine/rs_arc.cpp:641
RS2::Ending RS_Arc::getTrimPoint(... is buggy: it chooses often the right ending, but not in all cases.
I have replaced this code with the (some lines longer) code from LC1, and it works perfect.

Discussion

  • Dongxu Li

    Dongxu Li - 2013-02-24

    not enough info here.

    Please provide a testcase and steps to reproduce.

    Still pushed a commit to master:

    6a23795..18201c2

     
  • Dietmar Kuehn

    Dietmar Kuehn - 2013-02-25

    Hi Dongxu,
    sorry, but Your commit doesn't work correkt, test it with attached file.
    The old code from LC1 works better.

     
  • Dietmar Kuehn

    Dietmar Kuehn - 2013-02-25
     
    Attachments
  • Dongxu Li

    Dongxu Li - 2013-03-03
    • assigned_to: nobody --> dongxuli
    • labels: 2396693 --> actions
    • status: open --> open-accepted
     
  • Dongxu Li

    Dongxu Li - 2013-03-03

    I only tested trim1.

    trim2 needs cleanup here.

     
  • Dongxu Li

    Dongxu Li - 2013-12-27
    • Group: master branch --> 2.1
     
  • Dongxu Li

    Dongxu Li - 2013-12-27

    will fix after 2.0 release

     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks