On Sun, Apr 18, 2010 at 5:15 PM, Arvid Picciani <ae...@ex...> wrote:
> On Sun, 18 Apr 2010 12:04:18 +0300, J-P Nurmi <jp...@gm...> wrote:
>
>> Furthermore, I ran tests/other/app to check that QxtGui is mostly
>> fine. You guys might want to give it a quick try as well
>
> Works for me on heresy,archlinux, and ubuntu.
Good. I'm proposing that we package the release already today if
somebody has time for that.
>> PS. Please don't accept contributions that add named branches.
>> Mercurial's named branches are more or less permanent. Thus, now we
>> have a "changes" branch from marcusl there. :( Instead of blindly
>> pushing contributed changes in, you can for example create a diff from
>> the changes (especially if it's a messy bunch of change sets ie. not a
>> single revision) and then apply a clean patch.
>
> i pulled them in with the named branch on purpose. i don't see whats
> wrong with it.
$ hg branches
default 1879:0034a43b85e4
0.6 1878:bf0846459ced
0.5 1759:2dd3424cb69d
0.4 1307:753311dcae94
0.2 620:643f45a9c85c
changes 1798:5a46ad58c9e4 (inactive)
0.2.4 617:89e192777962 (inactive)
We have a clean structure there, which is important to have when
dealing with multiple branches ie. maintaining older 0.x series. If
you accept arbitrarily named personal branches there, it will be very
very messy in the long run. You don't want named branches like
"arvids-foo-tryout", "adams-web-fixes" or "jp-0wns-j00" there, right?
:-)
--
J-P Nurmi
|