Re: [Libquicktime-devel] get_conversion_price <- Yep, hit send too quick

[Burkhard P. <bur...@ig...>]

Hi,

Am 07.12.2013 22:26, schrieb Erik Johansson:
> On Fri, Dec 6, 2013 at 6:25 PM, Burkhard Plaum
> <bur...@ig...> wrote:
>> - colormodel_is_legal_range() is a misleading name. Are there illegal ranges too?
>
> Arguably yes, though I tend to call that full range rather than illegal :o)
>
>>     I'd call it lqt_colormodel_is_video_range(). Maybe it can even be made public.
>
> Google seems to suggest that the legal- and video range terms get used
> roughly equally. Changed to video and made public.
>
>> - The approach for calculating the price for different chroma subsampling is
>>     much better, but not optimal yet. With your approach, converting 4:4:4 to 4:2:2
>>     has the same price as 4:4:4 to 4:1:1. Could we think about something like:
>>
>>     if(input_sub_h < output_sub_h)
>>       price += some_constant * (output_sub_h - input_sub_h);
>
> Fixed.
>
>> - The subsampling should also take RGB formats into account (with sub_h = 1 and
>>     sub_v = 1). BC_RGB888 -> BC_YUV420P should be worse than BC_RGB888 -> BC_YUV444P,
>>     or not?
>
> That was covered in the last patch already; if(input_is_rgb &&
> output_is_yuv){...}. I've tidied up that logic somewhat, initialising
> the *_sub_{h,v} variables to 1 for RGB formats.

Patch applied

Burkhard