Re: [Libquicktime-devel] libquicktime on windows

[Burkhard P. <bur...@ig...>]

Hi,

Am 07.10.2013 17:00, schrieb Christian Ebert:
> * Burkhard Plaum on Monday, October 07, 2013 at 16:39:12 +0200
>> Am 03.10.2013 17:07, schrieb Derek Chow:
>>> cool,
>>>
>>>> Applied 004_localtime_s.patch with a tiny fix
>>>> _localtime64_s was ifdefed with HAVE__LOCALTIME32_S instead of HAVE__LOCALTIME64_S
>>>
>>> Looking back at that patch, I reckon the check for defined(_WIN64) is also probably unnecessary.
>>> How about a further change to just see if these msvcrt methods are available when we resort to
>>> them (see attached win_localtime.diff)?
>>
>> Agree, applied.
>>
>>>> So from what I see, the only missing issues are the HAVE_SYS_PARAM_H check from 003_getpagesize.patch
>>>> and testing 005_libtool_dll_fix.patch on some other systems.
>>>
>>> FYI I've used 005_libtool_dll_fix.patch for builds on linux with no apparent issues.
>>
>> Applied
>
> The above, or one of the above causes build to fail on Mac OS
> 10.8.5:

[...]

Oops.

Ok, I introduced a variable MODULE_LDFLAGS, which is set by configure and used in
plugins/*/Makefile.am

Currently it's set to "-no-undefined" just for Linux. It can easily be tweaked for other
systems depending on the variable $host_os, but I don't know what values $host_os has on
Win32 and Win64. Maybe Derek can find this out and make a patch for configure.ac.

Burkhard