Re: [Libquicktime-devel] faac plugin fixes

[Burkhard P. <pl...@ip...>]

Hi,

Am 26.04.2013 15:53, schrieb Erik Johansson:
> My last mail came through horribly garbled - sorry about that!
> Original text included below.
>
> Regards
> // Erik
>
>> Hello,
>>
>> I came across two bugs in the faac plugin.
>>
>> Faac adds one frame of priming delay, i.e. 1024 samples. The bug in the faac
>> plugin is that it only writes the provided number of encoded samples to the
>> output, meaning that since the first 1024 will be priming, the last 1024
>> samples will be lost. I solved this by adding a new configuration parameter:
>>
>>      {
>>        .name =        "faac_priming_delay",
>>        .real_name =   TRS("Priming delay (samples)"),
>>        .type =        LQT_PARAMETER_INT,
>>        .val_min =     { .val_int = FAAC_PRIMING_DELAY },
>>        .val_default = { .val_int = 2112 },
>>      },
>>
>> I choose 2112 samples as the default, since that is the value Apple seems to
>> use when encoding AAC.  (There is a pretty good discussion on priming in
>> this thread:
>> https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2012-July/127839.html)
>>
>> The second bug was more trivial; configuration parameter names in lqt_faac.c
>> didn't match those expected by the set_parameter function in faac.c. Solved
>> by adding 'faac_' prefixes to the affected parameter names.
>>

Applied. The prime samples thing is a good catch by the way. They are often
ignored.

Burkhard