Re: [Libquicktime-devel] [PATCH] Add another IMX fourcc

[Burkhard P. <pl...@ip...>]

Hi,

Am 18.04.2013 18:11, schrieb Joseph Artsimovich:
> Hi,
>
> The attached patch adds 'AVmp' to the list of IMX fourcc's. From what I understand, it's
 > more or less equivalent to 'mx5p', with the only difference being the vendor (Avid vs Sony).

applied.

> On a side note, libquicktime no longer builds with the latest ffmpeg from git. They removed the
 > AVCODEC_MAX_AUDIO_FRAME_SIZE define from a public header. I am not sure how to fix that.

 From what I see, it is used only in the decoding part in 2 lines like:
new_samples = num_samples + AVCODEC_MAX_AUDIO_FRAME_SIZE / (2 * track_map->channels);

which look like some safety margin so we don't crash on broken files.
Maybe setting

new_samples = num_samples + 8192;

would be a completely perfect "fix". The number is only used for allocating the buffer for
decoded samples.

Also from what I see the code assumes, that audio samples are always 16 bit (which was true in
earlier ffmpeg versions), but now we can also have 32 bit floating point output.

Burkhard