[Libproxydetect-devel] [Fwd: Re: libproxydetect]

[Augustus S. <aug...@ve...>]

-------- Original Message --------
Subject: Re: libproxydetect
Date: Mon, 14 Oct 2002 12:55:26 -0700
From: Augustus Saunders <aug...@ve...>
To: Daniel Stenberg <da...@ha...>
References: <Pin...@pm...>



Daniel Stenberg wrote:

>Cool. I have some immediate comments on what you have now (I realize this may
>be a bit premature for some of them, but feel free to ignore what you don't
>agree with). They're all pretty minor, the API seems simple and
>straight-forward enough to work nicely.
>
> o Don't use C++/C99 comments. We aim for maximum portability and that
>   includes older ANSI compilers that do old-style /* comments */ only.
>
Yeah, I always forget.  I'm a C++ coder these days, and I tend to forget 
little differences.

> o LIBPROXY_PROXY_SOURCE - is this only supposed to be used for returning
>   where the info was from, or should the user be able to set a preferred
>   place to get the info from?
>
I was thinking that you could pass in a specific source, like Netscape, 
if you wanted to ensure that we
only get the info from there.  Or, you could pass in ANY as a source, 
causing us to search through all
known sources (on that platform).  In that case, the source where the 
information actually came from
would be placed in that parameter.

> o I missed user+password for the proxy authentication?
>
For neither IE or Mozilla stores your username:passwd for proxy auth. 
 I'll add functions to the API for
that when we add a source that actually has the info.

> o There are Windows-proxies that require NTLM-authentication, so isn't is
>   possible to extract what kind of athentication the proxy wants on windows?
>   There's also the Digest kind (hard ever used but defined in standards).
>
Hmm, I don't know what NTLM authentication is.  Can you explain?

> o All functions have a 'get_proxy' prefix, except the get_exempt_* ones. Is
>   that on purpose? Using a generic prefix for all functions is a good thing,
>   IMHO.
>
No, that was an oversight.  

Ok, Thanks for the feedback.  Hopefully, over the next couple of weeks, 
I can push this into a useable
state for IE and Netscape on Windows.  Cheers-

Augustus