-------- Original Message --------
Subject: Re: libproxydetect
Date: Sat, 12 Oct 2002 13:49:53 +0200 (MET DST)
From: Daniel Stenberg <da...@ha...>
To: Augustus Saunders <aug...@ve...>
On Fri, 11 Oct 2002, Augustus Saunders wrote:
> Daniel, I have gotten a sourceforge project:
> http://www.sourceforge.net/projects/libproxydetect. I have posted some
> early files and would appreciate it if you could take a look at the API and
> tell me what you think. Basically, just read through libproxydetect.h.
> Not all of the functions are implemented yet, but those files compiled for
> me under MSVC. Over the next couple of weeks, I want to add Netscape
> support, and I'll hopefully test under Cygwin and maybe Linux as well.
> Any feedback you have would be great. Cheers-
Cool. I have some immediate comments on what you have now (I realize this may
be a bit premature for some of them, but feel free to ignore what you don't
agree with). They're all pretty minor, the API seems simple and
straight-forward enough to work nicely.
o Don't use C++/C99 comments. We aim for maximum portability and that
includes older ANSI compilers that do old-style /* comments */ only.
o LIBPROXY_PROXY_SOURCE - is this only supposed to be used for returning
where the info was from, or should the user be able to set a preferred
place to get the info from?
o I missed user+password for the proxy authentication?
o There are Windows-proxies that require NTLM-authentication, so isn't is
possible to extract what kind of athentication the proxy wants on windows?
There's also the Digest kind (hard ever used but defined in standards).
o All functions have a 'get_proxy' prefix, except the get_exempt_* ones. Is
that on purpose? Using a generic prefix for all functions is a good thing,
IMHO.
> BTW, I am still planning on putting a patch together for a proxy
> authentication callback function in libcurl.
Neato.
--
Daniel Stenberg - http://daniel.haxx.se - +46-705-44 31 77
ech`echo xiun|tr nu oc|sed 'sx\([sx]\)\([xoi]\)xo un\2\1 is xg'`ol
|
