[Libphidget-devel] Serial...

[Vadim T. <vt...@fr...>]

Jack,

Code for extracting the serial number looks funny (phidget.c from 651 to
659).

Line 658: j is never used again...

General: one-letter variable names are evil...

Question to self: how does C support Unicode?

Another one: how come that GCC compiles the code that mustn't compile under
true C?

servo_example.cc: you've probably noticed that the Version string is not
null-terminated... I believe there's a CVS pseudo-variable name for what
you're trying to achieve, though I don't remember it right now. Plus, don't
forget that *that* is the *revision* of servo_example.cc file, not the
general version - in order to have that, you'll have to get the @VERSION@ -
probably make configure.in create config.h - that's a long story.

I'm not going to fix anything now, just want to get the overall picture
before that.

--vt