Re: [Libphidget-devel] just playing with indent . . .

[Jack S. <js...@ja...>]

On Mon, 2002-09-09 at 19:02, Vadim Tkachenko wrote:
> According to Jack Strohm:
> 
> > Now with indent support I did this:
> > 
> > cvs update
> > make indent-local
> > make indent
> > cvs commit
> > 
> > And I get this:
> > 
> > CVS:
> > ----------------------------------------------------------------------
> > CVS: Enter Log.  Lines beginning with `CVS:' are removed automatically
> > CVS:
> > CVS: Committing in .
> > CVS:
> > CVS: Modified Files:
> > CVS:    src/examples/phidget_c.c src/examples/phidget_cpp.cc
> > CVS:    src/libphidget/phidget.c src/libphidget/phidget.h
> > CVS:    src/phidget++/CAnalogIn.cc src/phidget++/CAnalogIn.h
> > CVS:    src/phidget++/CDigitalIn.cc src/phidget++/CDigitalIn.h
> > CVS:    src/phidget++/CDigitalOut.cc src/phidget++/CDigitalOut.h
> > CVS:    src/phidget++/CInterfaceKit.cc src/phidget++/CPhidget.cc
> > CVS:    src/phidget++/CPhidget.h src/phidget++/CPhidgetManager.cc
> > CVS:    src/phidget++/CPhidgetManager.h src/phidget++/CServo.cc
> > CVS:    src/phidget++/CServo.h src/phidget++/CServoController.cc
> > CVS:    src/phidget++/CServoController.h src/phidget++/CUID.cc
> > CVS:    src/phidget++/CUID.h src/phidget++/CUniqueDevice.cc
> > CVS:    src/phidget++/CUniqueDevice.h src/phidget++/TSingleton.h
> > CVS:    src/phidget++/lsphidget.cc
> > CVS:
> > ----------------------------------------------------------------------
> > 
> > 
> > I didn't go ahead with it, but is it going to actually commit all these
> > files, or will it actually see that while the date change, nothing in
> > them changed, just wondering.
> 
> Do 'cvs diff' and see what's different.
> 
> Often, CVS goes nuts even if just the timestamp changed - it will report
> those files on commit time after time. If the 'cvs diff' is empty, you're
> fine. If it is not, run 'make indent' again couple of times and see if it
> goes away.
> 
> I'm thinking about a) looking at the parts of the code it keeps juggling b)
> submitting a bug report to indent development team. This behavior defeats
> the purpose...

"make indent" should put the code in the same form that the is stored in
CVS right?

well here is what I do after checking it out:

[jstrohm@oishi libphidget]$ bootstrap
[jstrohm@oishi libphidget]$ cvs diff
js...@cv...'s password:
cvs server: Diffing .
cvs server: Diffing misc
cvs server: Diffing src
cvs server: Diffing src/examples
cvs server: Diffing src/libphidget
cvs server: Diffing src/phidget++
cvs server: Diffing src/rpm
cvs server: Diffing src/scripts
cvs server: Diffing src/scripts/install
[jstrohm@oishi libphidget]$ cvs diff
js...@cv...'s password:
cvs server: Diffing .
cvs server: Diffing misc
cvs server: Diffing src
cvs server: Diffing src/examples
cvs server: Diffing src/libphidget
cvs server: Diffing src/phidget++
Index: src/phidget++/CAnalogIn.cc
===================================================================
RCS file: /cvsroot/libphidget/libphidget/src/phidget++/CAnalogIn.cc,v
retrieving revision 1.3
diff -u -r1.3 CAnalogIn.cc
--- src/phidget++/CAnalogIn.cc  8 Sep 2002 18:59:54 -0000       1.3
+++ src/phidget++/CAnalogIn.cc  10 Sep 2002 00:14:11 -0000
@@ -12,6 +12,8 @@

 CAnalogIn::CAnalogIn (CInterfaceKit * interfacekit, int id):
 CUniqueDevice (interfacekit, id),
-_interfaceKit (interfacekit), _value (0), _lastValue (0)
+_interfaceKit (interfacekit),
+_value (0),
+_lastValue (0)
 {
 }
Index: src/phidget++/CDigitalIn.cc
===================================================================
RCS file: /cvsroot/libphidget/libphidget/src/phidget++/CDigitalIn.cc,v
retrieving revision 1.3
diff -u -r1.3 CDigitalIn.cc
--- src/phidget++/CDigitalIn.cc 8 Sep 2002 18:59:54 -0000       1.3
+++ src/phidget++/CDigitalIn.cc 10 Sep 2002 00:14:11 -0000
@@ -11,6 +11,8 @@
 #include "CInterfaceKit.h"

 CDigitalIn::CDigitalIn (CInterfaceKit * interfacekit, int id):
-CUniqueDevice (interfacekit, id), _value (false), _lastValue (false)
+CUniqueDevice (interfacekit, id),
+_value (false),
+_lastValue (false)
 {
 }
Index: src/phidget++/CDigitalOut.cc
===================================================================
RCS file: /cvsroot/libphidget/libphidget/src/phidget++/CDigitalOut.cc,v
retrieving revision 1.3
diff -u -r1.3 CDigitalOut.cc
--- src/phidget++/CDigitalOut.cc        8 Sep 2002 18:59:54 -0000      
1.3
+++ src/phidget++/CDigitalOut.cc        10 Sep 2002 00:14:11 -0000
@@ -11,7 +11,8 @@
 #include "CInterfaceKit.h"

 CDigitalOut::CDigitalOut (CInterfaceKit * interfacekit, int id):
-CUniqueDevice (interfacekit, id), _value (false)
+CUniqueDevice (interfacekit, id),
+_value (false)
 {
 }

.
.
.
.
.
.