From: Ivan K. <kry...@gm...> - 2019-05-12 19:44:49
|
Dear liborigin maintainers, As a maintainer of Ropj package[1], I had to make small fixes to liborigin; all of them are available at [2]. I would like to propose at least some of them for merging back into liborigin to prevent fragmentation. The changes include: - [3] prevent undefined behaviour caused by having invalid values in enums and bools (direct assignment and uninitialised stack garbage) - [4] prevent a small memory leak in projectTree caused by the whole tree being placed below the feet of the tree, preventing it from being freed by destructor And a smaller change required by CRAN policy: remove explicit reference to std::cout from outputProjectTree[5], since R extensions are not allowed to touch stdout directly. If you are interested, I can prepare the patches in a form convenient for you to merge. -- Best regards, Ivan [1] https://cran.r-project.org/package=Ropj makes it possible to import OPJ files into R, a language for data analysis. [2] https://github.com/aitap/Ropj/commits/liborigin [3] https://github.com/aitap/Ropj/commit/ce1374741152ae41012542b3e16fd6889097d527 [4] https://github.com/aitap/Ropj/commit/cc73f0f708ae457a8f26d3295ae4fb5023b4dafd [5] https://github.com/aitap/Ropj/commit/cc73f0f708ae457a8f26d3295ae4fb5023b4dafd + https://github.com/aitap/Ropj/commit/f22cd9fab08ecb3e163919249d0bfcc2191dad1d |