Re: [Liborigin-devel] [PATCH 1/3] Add install target and remove linking against Qt libs

[Miquel G. <gbm...@gm...>]

2010/11/1 Knut Franke <Knu...@gm...>:
> [ Sorry for not replying properly; I managed to screw up my first subscription
> attempt and didn't receive the first three mails. ]
>
>> +targeta.path = $$INSTALLBASE/lib/liborigin2
> [...]
>> +targeta.files = liborigin2.a
>
> As far as I can see, qmake can build either a static or a dynamic library, but
> not both at the same time. Adding just this installation target will install
> whatever liborigin2.a happens to be lieing around from the last time
> qmake;make was run with CONFIG+=staticlib enabled, which is not a good idea
> IMHO.
Not exactly, if you follow the instructions in README. The command
"qmake liborigin2.pro"
(i.e. without  CONFIG+=staticlib enabled) produces a Makefile with both
a (default) dynamic library target and also a static library target.
Therefore, the following commands
qmake liborigin2.pro; make; make clean; make staticlib; make install
should compile and install both libraries.

> Instead of trying to work around the various shortcomings of qmake, I'd
> suggest resurrecting CMakeLists.txt from commit f19437 (with a suitably
> updated VERSION). This is also a much smaller dependency than Qt (assuming
> someone wants to use liborigin in a non-Qt context), and LabPlot2 / future
> SciDAVis will most likely be using CMake anyway.
I would prefer to wait for that change until at least LabPlot2 or
SciDAVis do change
to CMake. After all, the best use of liborigin2 capabilities is still
done with qmake driven applications. Another possibility would be to
keep both (qmake and CMake) building
scripts.

Miquel