Dear Ivan,
thank you very much for letting us know. Nice to know that liborigin is
used in more and more projects.
Providing patches would be very handy. I will check and apply them as
soon as possible.
best wishes
Stefan
On 5/12/19 9:40 PM, Ivan Krylov wrote:
> Dear liborigin maintainers,
>
> As a maintainer of Ropj package[1], I had to make small fixes to
> liborigin; all of them are available at [2].
>
> I would like to propose at least some of them for merging back into
> liborigin to prevent fragmentation. The changes include:
>
> - [3] prevent undefined behaviour caused by having invalid values in
> enums and bools (direct assignment and uninitialised stack garbage)
> - [4] prevent a small memory leak in projectTree caused by the whole
> tree being placed below the feet of the tree, preventing it from
> being freed by destructor
>
> And a smaller change required by CRAN policy: remove explicit
> reference to std::cout from outputProjectTree[5], since R extensions
> are not allowed to touch stdout directly.
>
> If you are interested, I can prepare the patches in a form convenient
> for you to merge.
>
|
