#24 Shared library call to exit() function

[Alexander Ploumistos]

Hello,

Not really sure if this is really a bug, but I thought it best to report it.
While packaging the new version for Fedora, I got this warning from rpmlint:

liborigin.x86_64: W: shared-lib-calls-exit /usr/lib64/liborigin.so.3.0.0 exit@GLIBC_2.2.5

As far as I can tell, this means that when something triggers the exit call, the program that called the library will also exit, is this correct? If so, is this the intended behavior?

Best regards,
Alex

[gbm]

Thanks for the report.
There are two remainig 'exit' calls in OriginFile.cpp that in normal use of the library should never show up.
The attached patch removes them by using a better approach to handle the "No such file.." and "Permission denied" errors.
Miquel

[Alexander Ploumistos]

Thanks Miquel, I don't see the warning any more.

On an unrelated question, how can I build opj2dat so that it uses the shared library and not the static one?

[gbm]

You can use:
g++ -o opj2dat $(pkg-config --cflags --libs liborigin) opj2dat.cpp
Miquel

[Alexander Ploumistos]

Thank you, so that means I should find out how bootstrapping works with rpms…

[gbm]

You can use the attached patch.
Don't forget to add the generated liborigin.pc to the liborigin-devel package.

[Alexander Ploumistos]

I have submitted a liborigin-3.0.0-3 update which should already be available in rawhide. As soon as the updates hit stable, I will submit an update for scidavis, because I hadn't noticed that v1.23.4 included the change (bug 1652697).
Once more, than you very much Miquel!