Re: [opendbx] new OpenDBX 1.4 stable release?

[Murray S. K. <ms...@cl...>]

> -----Original Message-----
> From: Norbert Sendetzky [mailto:no...@li...]
> Sent: Wednesday, May 23, 2012 1:55 AM
> To: OpenDBX devel list
> Subject: Re: [opendbx] new OpenDBX 1.4 stable release?
> 
> Hi Guille
> 
> > I was wandering when will you release a new version of OpenDBX with
> > the latest fixes :). Maybe you still have stuff to add...
> > I can try to build the windows binares for most platforms -if not all-
> > to put in the website but not before I know you freeze it ;).
> 
> Yes, there's one open task left: A workaround for the broken PostgreSQL
> error handling reported by Murray.

My workaround isn't pretty: If odbx_query() fails and the error string returned by PostgreSQL via odbx_error() starts with "FATAL:", then ignore the error type reported by odbx_error_type() and force a manual reconnect attempt.  If that still fails, then abort completely.

The issue is that PQstatus() can return CONNECTION_OK when it's not.  In particular, even after a result request returns a fatal error, PQstatus() reports the connection is okay, which in turn confuses OpenDBX.  This is easily reproduced by making a connection via OpenDBX, issuing a query and getting its results, then restarting PostgreSQL, then repeating the query.  Although the connection is most assuredly dead now, PQstatus() says it's fine.

See http://archives.postgresql.org/pgsql-bugs/2011-01/msg00097.php for my bug report and the ensuing conversation.

-MSK