Re: [opendbx] Several problems with OpenDBX

[Norbert S. <no...@li...>]

On 10/25/2011 10:06 PM, Alex Ott wrote:
>> Yes, the sqlite3 backend doesn't care about slashes/backslashes at the
>> end of the path, so it don't have to care about Unix/Windows differences
>> (also noted here:
>> http://linuxnetworks.de/doc/index.php/OpenDBX/Configuration#sqlite3_backend)
>
> This could be noted, but simple patch can fix this, making better experience

Your patch is not enough as it misses the handling for the differences 
between Unix/Windows. If I would add your patch as is, the code for the 
sqlite3 backend would stop working on Windows systems.

>> If you don't let the destructor do the work, you have to care about the
>> correct sequence yourself (new Conn(), bind(), ..., unbind(), finish()).
>> It's the same as in the procedural interface. Maybe we can improve the
>> situation if we call Conn.unbind() in Conn.finish() if it's not done before.
>
> I allow destructor to care, but it should depend on which functions
> was called already&  which not...

Done in rev. 354

> P.S. I already switched from OpenDBX, as using it I got mysterious
> crashes due memory corruption...

Sorry to hear that.


Norbert