Re: [opendbx] More fun with postgresql

[Murray S. K. <ms...@cl...>]

> -----Original Message-----
> From: Norbert Sendetzky [mailto:no...@li...]
> Sent: Thursday, June 16, 2011 1:47 PM
> To: OpenDBX devel list
> Subject: Re: [opendbx] More fun with postgresql
> 
> Hi Murray
> 
> libpq seems to be a source of eternal fun ;-)

Indeed.  I don't think their handling of the last report I gave them was all that great so I'm fence-sitting about mentioning this one.

My current workaround is simply to short-circuit a query containing high-ASCII, reporting it as "not found" back to the application before it ever tries talking to libpq.  It would be nice to get this addressed though.

> The last odbx_result_finish() should not be called because no result
> handle is returned and in the worst case a duplicate free() could
> happen.

I have it protected by a check for a NULL result, so we're safe there.

> For a test you can try to call odbx_result() again after the error
> occured. Maybe a second call to PQgetResult() may help. If yes, we may
> be able to change the pgsql_odbx_result() for this special case.

That'll be a pain to get into my current code, but I can hack it in as a test and at least find out if your theory is sound.  I'll report back when I have done so.

-MSK