Let me start by saying I'm very impressed with your ONVIF Library! I really appreciate the fact that this is the first C++ usable library to implement the ONVIF standard that I have come across that actually works -- kudos on that! I particularly like how you simplified things by combining all data in a single struct and constraining profiles to a single H264 encoded profile. That really simplifies things over a diverse range of camera types.
I'm just getting acquainted with it, so I may still be missing some understanding, but after reviewing the source, I do not see any code that provides tokens for the VideoEncoderConfiguration or the VideoSourceConfiguration, which are both required for other methods to work. If I'm missing something, please enlighten me!
In the meantime, I'm simply parsing them out of the XML reply for the getFirstProfileToken, which I'm considering renaming to getFirstProfileTokens. My employer suggested that I offer to make a pull-request, but I'm unfamiliar with SourceForge contributing practices, nor do I know if that is something you're agreeable to. Otherwise, I intend to fork this on a GitHub account.
Thanks for sharing this great library you have created! @kp-coder
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Thank you so much for your kind words, I'm glad you found the library to be useful. If I remember correctly, the fillRTSP command populates the data structure with the necessary tokens so that you can use other commands such as VideoEncoderConfiguration without further initialization.
There is an existing copy of the code for libonvif on github if you would like to fork from there.
My apologies for the late reply, I hadn't checked the comments for a while. If you need more help, feel free to send another message.
Best Regards,
Stephen
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I'm fairly certain that the code I downloaded from here at SourceForge does not. I encourage you to remedy this, so that others may enjoy this great contribution of yours readily upon download.
Thanks, again!
Kevin
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Hi @sr99622,
Let me start by saying I'm very impressed with your ONVIF Library! I really appreciate the fact that this is the first C++ usable library to implement the ONVIF standard that I have come across that actually works -- kudos on that! I particularly like how you simplified things by combining all data in a single struct and constraining profiles to a single H264 encoded profile. That really simplifies things over a diverse range of camera types.
I'm just getting acquainted with it, so I may still be missing some understanding, but after reviewing the source, I do not see any code that provides tokens for the VideoEncoderConfiguration or the VideoSourceConfiguration, which are both required for other methods to work. If I'm missing something, please enlighten me!
In the meantime, I'm simply parsing them out of the XML reply for the getFirstProfileToken, which I'm considering renaming to getFirstProfileTokens. My employer suggested that I offer to make a pull-request, but I'm unfamiliar with SourceForge contributing practices, nor do I know if that is something you're agreeable to. Otherwise, I intend to fork this on a GitHub account.
Thanks for sharing this great library you have created!
@kp-coder
Hi Kevin,
Thank you so much for your kind words, I'm glad you found the library to be useful. If I remember correctly, the fillRTSP command populates the data structure with the necessary tokens so that you can use other commands such as VideoEncoderConfiguration without further initialization.
There is an existing copy of the code for libonvif on github if you would like to fork from there.
My apologies for the late reply, I hadn't checked the comments for a while. If you need more help, feel free to send another message.
Best Regards,
Stephen
Hi Stephen,
Thanks for the response!
I found the github repo you recommended, and I have verified that you do pull out the necessary tokens in that repo, here: https://github.com/sr99622/libonvif/blob/master/source/onvif.c#L665
I'm fairly certain that the code I downloaded from here at SourceForge does not. I encourage you to remedy this, so that others may enjoy this great contribution of yours readily upon download.
Thanks, again!
Kevin