Menu

#14 function ln_get_ell_orbit_len not returning the correct value

v1.0_(example)
closed-fixed
None
5
2015-03-19
2015-03-19
Emilio
No

Hello, i noticed that the function
double ln_get_ell_orbit_len (struct ln_ell_orbit * orbit)

has the variable H not used and its return value is
return M_PI * (( 21.0 * A - 2.0 * G - 3.0 * G) / 8.0);
while it should be (according to Meeus)
return M_PI * (( 21.0 * A - 2.0 * G - 3.0 * H) / 8.0);
for correctly returning the ellipse length.
thanks for your work on this great library, i've discovered it recently and it is a sort of overall answer to my need for astronomical calculation
Regards
Emilio

Discussion

  • Liam Girdwood

    Liam Girdwood - 2015-03-19

    Thanks Emilio, this has already been fixed in git 5a7b703a7de275aae810a7bd3321a9a2b4952b7c

     
  • Liam Girdwood

    Liam Girdwood - 2015-03-19
    • status: open --> closed-fixed
     

Log in to post a comment.