Re: [Libmusicxml-devel] xml2guido

[Dominique F. <fo...@gr...>]

> Le 13 sept. 2016 à 18:46, Arshia Cont <ars...@an...> a écrit :
> 
> Hello all,
> 
> I just pushed a new brach on the Github dealing with MusicXML to Guido conversion, including (but not limited to):
> 
> - Importing Rehearsal Marks using the new Enclosure attribute of Mark in Guido
> 
> - Improving articulations on ‘chords’
> 
> - Importing Lyrics as close as possible to MusicXML (note that there are 2 design choices, where the most Guido-esque is commented).

excellent ! I’ve got it and the result is fine.
It looks like your branch is based on the master branch. I’ve merged the ‘dev’ branch to your branch (just a couple of changes), it provides the make utilities in the build folder as well as some improvements (see the change log).
The merged branch has been pushed back to github.

In order to maintain the changes history, could you put your improvements into the CHANGELOG.txt file as well as check the versions numbers (in versions.cpp), the xml2guido version should be increased.

Should I merge your changes to the ‘dev’ branch or should I wait for more tests?
In a second step, new binary packages will be published and everything merged to the master branch.

Here comes the question of validation: in samples/musixml, there is already a set of xml files  and a makefile that converts them to gmn files. You could add files that include the new handled elements. Now validation itself is still manual: you have to open the output file and look for correctness.
That could be made a bit more automatic by comparison with a set of reference files. What do you think ?
—
Dom



> 
> I’ll be pushing more to this branch in the coming weeks as we test and improve.
> 
> Hope people will find it useful.
> 
> 
> Arshia
> ------------------------------------------------------------------------------
> _______________________________________________
> Libmusicxml-devel mailing list
> Lib...@li...
> https://lists.sourceforge.net/lists/listinfo/libmusicxml-devel