Re: [mpeg2-dev] [PATCH] fix incorrect FSF address in license headers

[Diego B. <di...@bi...>]

On Thu, Oct 09, 2008 at 05:16:50PM +0200, Lionel Debroux wrote:
> Diego Biurrun wrote:
> 
> > > A nitpick about your patch that updates the FSF address: I
> > > noticed that trunk/src/getopt.{c,h} remain untouched.
> > 
> > Yes, that was done on purpose,
> Ah, OK.
> > these files are from glibc, not libmpeg2.
> Indeed, but is there something that prevents the libmpeg2 project from
> updating the FSF address in files originating from glibc and contained
> in libmpeg2, on the occasion of the same correction of factual
> information that has become wrong, in other files of the libmpeg2 project ?

Only the fact that the diff to the upstream versions of the files gets
bigger.

> >> What do people think ?
> > 
> > Your patch is wrong.
> > [snip]
> > Before your change this file was licensed LGPL, now it is a weird
> > mix of GPL and LGPL.  Also, before it said the file pertained to
> > the GNU C library, now it claims to belong to the GNU C library
> > in two places and to mpeg2dec in another place.
> Doh. Screw copy&paste without re-reading. Thanks for pointing out my
> mistake.
> 
> 
> What do you, and others, think about upgrading the getopt files ?

If by upgrading you mean fixing the license header like I just did for
libmpeg2 then my answer is: I would leave the files untouched since
they are externally imported files.

You could of course send the GNU C library people a patch to fix this.
It's incredibly lame that not even the core GNU projects get this right.

Diego