Re: [mpeg2-dev] [PATCH] fix incorrect FSF address in license headers

[Diego B. <di...@bi...>]

On Thu, Oct 09, 2008 at 03:12:15PM +0200, Lionel Debroux wrote:
> 
> A nitpick about your patch that updates the FSF address: I noticed that
> trunk/src/getopt.{c,h} remain untouched.

Yes, that was done on purpose, these files are from glibc, not libmpeg2.

> What do people think ?

Your patch is wrong.

> --- a/trunk/src/getopt.c
> +++ b/trunk/src/getopt.c
> @@ -16,10 +16,9 @@
>  
> -   You should have received a copy of the GNU Library General Public
> -   License along with the GNU C Library; see the file COPYING.LIB.  If not,
> -   write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330,
> -   Boston, MA 02111-1307, USA.  */
> +   You should have received a copy of the GNU General Public License along
> +   with mpeg2dec; if not, write to the Free Software Foundation, Inc.,
> +   51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.  */

Before your change this file was licensed LGPL, now it is a weird mix of
GPL and LGPL.  Also, before it said the file pertained to the GNU C
library, now it claims to belong to the GNU C library in two places and
to mpeg2dec in another place.

Diego