libmpeg2-devel

[mpeg2-dev] [PATCH] make headers compile standalone

[Diego B. <di...@bi...>]

Here is a patch to make libmpeg2 headers compile standalone.
This allows #including them directly without worrying about
header inclusion order or having to #include system headers
before libmpeg2 headers.

Diego

Re: [mpeg2-dev] [PATCH] make headers compile standalone

[Sam H. <sa...@ho...>]

On Thu, Jun 10, 2010, Diego Biurrun wrote:
> Here is a patch to make libmpeg2 headers compile standalone.
> This allows #including them directly without worrying about
> header inclusion order or having to #include system headers
> before libmpeg2 headers.

   I am worried about the <stdint.h> inclusions. This will likely break
compilation on Visual Studio until they have that header.

-- 
Sam.

Re: [mpeg2-dev] [PATCH] make headers compile standalone

[Diego B. <di...@bi...>]

On Fri, Jun 11, 2010 at 11:56:09AM +0200, Sam Hocevar wrote:
> On Thu, Jun 10, 2010, Diego Biurrun wrote:
> > Here is a patch to make libmpeg2 headers compile standalone.
> > This allows #including them directly without worrying about
> > header inclusion order or having to #include system headers
> > before libmpeg2 headers.
> 
>    I am worried about the <stdint.h> inclusions. This will likely break
> compilation on Visual Studio until they have that header.

How backwards can they be?  Do they have inttypes.h?

In any case the rest of the patch should be worth applying nonetheless.

Diego

Re: [mpeg2-dev] [PATCH] make headers compile standalone

[Diego B. <di...@bi...>]

On Sat, Jun 12, 2010 at 10:37:48AM +0200, Diego Biurrun wrote:
> On Fri, Jun 11, 2010 at 11:56:09AM +0200, Sam Hocevar wrote:
> > On Thu, Jun 10, 2010, Diego Biurrun wrote:
> > > Here is a patch to make libmpeg2 headers compile standalone.
> > > This allows #including them directly without worrying about
> > > header inclusion order or having to #include system headers
> > > before libmpeg2 headers.
> > 
> >    I am worried about the <stdint.h> inclusions. This will likely break
> > compilation on Visual Studio until they have that header.
> 
> How backwards can they be?  Do they have inttypes.h?
> 
> In any case the rest of the patch should be worth applying nonetheless.

Here is a version of the patch without the stdint.h #includes.
Please apply.

Diego

Re: [mpeg2-dev] [PATCH] make headers compile standalone

[Diego B. <di...@bi...>]

On Thu, Jun 24, 2010 at 10:41:22AM +0200, Diego Biurrun wrote:
> On Sat, Jun 12, 2010 at 10:37:48AM +0200, Diego Biurrun wrote:
> > On Fri, Jun 11, 2010 at 11:56:09AM +0200, Sam Hocevar wrote:
> > > On Thu, Jun 10, 2010, Diego Biurrun wrote:
> > > > Here is a patch to make libmpeg2 headers compile standalone.
> > > > This allows #including them directly without worrying about
> > > > header inclusion order or having to #include system headers
> > > > before libmpeg2 headers.
> > > 
> > >    I am worried about the <stdint.h> inclusions. This will likely break
> > > compilation on Visual Studio until they have that header.
> > 
> > How backwards can they be?  Do they have inttypes.h?
> > 
> > In any case the rest of the patch should be worth applying nonetheless.
> 
> Here is a version of the patch without the stdint.h #includes.
> Please apply.

*Here* is a version of said patch - *sigh*..

Diego

Re: [mpeg2-dev] [PATCH] make headers compile standalone

[Sam H. <sa...@ho...>]

On Thu, Jun 24, 2010, Diego Biurrun wrote:

> > Here is a version of the patch without the stdint.h #includes.
> > Please apply.

   Looks perfect. Thanks :-)

-- 
Sam.