Re: [Libmesh-users] Using gzstream from an app

[John P. <jwp...@gm...>]

I think you’ll need to run bootstrap at the top level and also commit those changes. Or you can wait for one of us to do it...

> On Jan 18, 2018, at 6:07 PM, David Knezevic <dav...@ak...> wrote:
> 
>> On Thu, Jan 18, 2018 at 5:58 PM, John Peterson <jwp...@gm...> wrote:
>> 
>> 
>>> On Thu, Jan 18, 2018 at 3:52 PM, Roy Stogner <roy...@ic...> wrote:
>>> 
>>> On Thu, 18 Jan 2018, John Peterson wrote:
>>> 
>>>> On Thu, Jan 18, 2018 at 2:07 PM, David Knezevic <dav...@ak...>
>>>> wrote:
>>>> 
>>>>> I configured with gzstream support, and I'd like to use this from an app.
>>>>> To do that I've copied gzstream.h to the app directory, and then it works,
>>>>> but I was wondering if it's possible to use libMesh's copy of gzstream.h
>>>>> directly? I guess not since it's not copied into the installed directory,
>>>>> is that right?
>>>>> 
>>>>> Anyway, any suggestions on the cleanest way to handle this would be
>>>>> appreciated.
>>>>> 
>>>> 
>>>> It looks like it would be as simple as adding the gzstream.h header to the
>>>> list of files that get installed by the build system?
>>>> 
>>>> I think this can be done by adding
>>>> 
>>>> nobase_include_HEADERS = gzstream.h
>>>> 
>>>> (see also the boost and Eigen Makefile.am files in contrib) to the
>>>> Makefile.am in contrib/gzstream and rebootstrapping, but I'm not an
>>>> automake expert by any means :-)
>>> 
>>> That's about it.
>>> 
>>> Did we avoid installing it because we were worried about collisions
>>> for users with a system gzstream.h installed, though?
>> 
>> I don't think it was actively avoided for any reason. As a rule we generally didn't install contrib headers that weren't included by our headers...
> 
> 
> The change you suggested works for me, thanks! I just made a PR with this one line change.
> 
> David
> 
>