Menu

#7 Please add this to src/lo_types_internal.h

Unstable (example)
open
nobody
None
5
2014-02-04
2014-01-31
nemysis
No

I'm FreeBSD maintainer for LibLO

http://www.freshports.org/audio/liblo/

Please add this enclosed patch than can good build in FreeBSD without patching.

Thanks

1 Attachments

Discussion

  • Stephen Sinclair

    Hi, your patch adds the line,

    #include <sys/socket.h>
    

    However, earlier in the same file there is the block,

    #ifdef HAVE_SYS_SOCKET_H
    #include <sys/types.h>
    #include <sys/socket.h>
    #endif
    

    This would imply to me that sys/socket.h is not detected correctly during configure, is that the case? Can you provide the output of running configure?

     

    Last edit: Stephen Sinclair 2014-02-04
  • nemysis

    nemysis - 2014-02-04

    I have now removed patch-src-lo_types_internal.h and tried again to build and get failures for lo_types_internal.h

     
  • Stephen Sinclair

    It seems your buildlog indicates that sys/socket.h is correctly detected, so I don't understand why HAVE_SYS_SOCKET_H would not be defined. Can you include your config.log file?

     
  • nemysis

    nemysis - 2014-02-04

    Here is config.log without my patch.

     
  • Stephen Sinclair

    Hello, I got a FreeBSD VM running in Qemu and reproduced the problem. I was able to fix it with only the first additional #include you propose, netinet/in.h. Adding sys/socket.h was not necessary. I'll be happy to add this line after some testing.

    Unfortunately, testlo failed for me, however.

     
  • nemysis

    nemysis - 2014-02-04

    Here build good LibLO with only added

    +#include <netinet in.h="">

    Thanks for testing :D

     

    Last edit: nemysis 2014-02-04

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.