Re: [Libjpeg-devel-6x] [patch] wrjpgcom possible buffer overflow in strcpy and strcat

[<sj...@sl...>]

Sounds good to me. :)

Quoting Tom Lane <tg...@ss...>:

> sj...@sl... writes:
>> Please review the following patch for wrjpgcom:
>
> FWIW, the solution that Red Hat had been using for some time was just to
> dike out the "MS-DOG" code here altogether, as it's not only not needed
> on systems with sane command parsing, but really wrong even without the
> buffer overrun issue: who says a comment can't start with a double quote?
> See
>
> http://pkgs.fedoraproject.org/cgit/libjpeg.git/tree/libjpeg-buf-oflo.patch
>
> I don't remember the exact genesis of that code fragment anymore, but it
> was obviously an under-thought-out reaction to somebody's complaint.  At
> this point I'd just remove it.
>
> 			regards, tom lane
>