Re: [Libjpeg-turbo-devel] Inclusion of iccjpeg.c and header file in libjpeg-turbo

[DRC <dco...@us...>]

I took a quick look at the code, and if I understand correctly, this
would add three new functions to the libjpeg API:

  setup_read_icc_profile()
  read_icc_profile()
  write_icc_profile()

Is that correct?  If so, then I would be open to including that feature
in libjpeg-turbo 1.6, although I need the following changes before I can
consider integrating and adopting the feature:

- Prefix the function names with "jpeg_" to be consistent with the rest
of the libjpeg API
- If possible, make setup_read_icc_profile() automatic.  It should be
possible to store a state variable in the jpeg_decompress_master
structure to indicate whether the setup function has been run, then
check that variable in the body of jpeg_read_icc_profile().
- Merge the function declarations from iccjpeg.h into jpeglib.h.
- Merge the API documentation from iccjpeg.h into libjpeg.txt (you can
add a new section to the document to accommodate this.)
- Add an appropriate copyright and license header to iccjpeg.c.  Refer
to the other copyright/license headers in the libjpeg API code for examples.
- Add options to cjpeg and djpeg that allow those programs to test the
ICC profile feature.  This will allow the appropriate regression tests
to be added to the build system.

I can do all of the above for you, but unfortunately not for free.  :(

DRC


On 12/3/16 5:53 PM, Thomas Weber wrote:
> Hi, 
> I would like to discuss a possible inclusion of iccjpeg.{c,h} into
> libjpeg-turbo. In 2013, Paweł Hajdan, Jr. already opened a discussion[1]
> about the possibility of such an inclusion, but there was no final
> decision.
> I maintain lcms in Debian and have a feature request open to expose
> iccjpeg via lcms' API[2], such that Chromium (and probably Firefox and
> lcms) could link against it.
> Looking at the discussion at [1], I have the feeling that the old
> discussion focused a bit too much on the fact that iccjpeg is currently
> part of lcms. While this is true, it is not really an integral part of
> lcms and ended up there more by accident. Indeed, it was originally
> meant for inclusion in libjpeg[3]. In lcms, it is today only used to
> build an utility named jpgicc, an ICC profile applier for JPEG.
> 
> [1] https://sourceforge.net/p/libjpeg-turbo/mailman/message/30387709/
> (sorry for not replying to that thread, but I did not find a way to
> extract the message-id)
> [2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=747839
> [3] https://github.com/mm2/Little-CMS/issues/37#issuecomment-66450180
> 
> 	Thomas