#8 event_ctcp_action clobbers target

closed-fixed
Interface (7)
5
2009-01-04
2009-01-02
No

the ACTION may be in a privmsg to a channel or direct. Currently, the event does not inform you which this is.

The fix is simple; on line 469 of libircclient.c, the target param is being clobbered.

Attaching suggested fix. Note that this fix does break backward compatibility to anyone relying on the previous functionality; however it is likely that anyone using the library will have patched it as not being able to determine the target of an action is most likely a problem for most consumers of this library.

Discussion

  • Nathan Ollerenshaw

    Changed the summary to accurately reflect the problem

     
  • Nathan Ollerenshaw

    • milestone: --> latest_stable_version
    • summary: event_ctcp_action needs optional channel name --> event_ctcp_action clobbers target
     
  • George Yunaev

    George Yunaev - 2009-01-03
    • status: open --> open-fixed
     
  • George Yunaev

    George Yunaev - 2009-01-03
    • status: open-fixed --> closed-fixed
     
  • Nathan Ollerenshaw

    • status: closed-fixed --> open
     
  • Nathan Ollerenshaw

    Hi Georgy, sorry to be a pain mate. Thanks for releasing a new version, but I need to reopen this bug.

    using irctest:
    Event "ACTION", origin: "chrome!~chrome@ncis.navy.mil", params: 2 [tests|ACTION tests]

    So, its still broken. Looking at the current release,

    params\[0\] = ctcp\_buf + 7; // the length of "ACTION "
    paramindex = 2;
    

    that params[0] needs to be params[1], or you still clobber the target.

    expected output:
    Event "ACTION", origin: "chrome!~chrome@ncis.navy.mil", params: 2 [#test|tests]

     
  • George Yunaev

    George Yunaev - 2009-01-04

    Packages updated. Thanks.

     
  • George Yunaev

    George Yunaev - 2009-01-04
    • status: open --> closed-fixed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks