[libexif-cvs] Re : libmnote canon support

[matthieu <ma...@if...>]

I have first to correct a bug with strncat(dest,source,size)=
 that i made
: the argument size is for source and not for dest so
strncat(v,"foo",sizeof(v)) is usless...

I see that you have also this bug in your lib, please correc=
t it...

[mat@localhost libmnote-0.5.6]$ grep -r strncat ../libexif-0=
.5.12/*
../libmnote-=20
0.5.6/* | grep -v binaire| grep -v "~"
../libexif-0.5.12/libexif/exif-entry.c:         strncat (v, =
" ", sizeof
(v) - 1)=20
;
../libexif-0.5.12/libexif/exif-entry.c:         strncat (v,
_("(Photographer)"),=20
 sizeof (v) - 1);
../libexif-0.5.12/libexif/exif-entry.c:         strncat (v, =
" - ",
sizeof (v) - =20
1);
../libexif-0.5.12/libexif/exif-entry.c:                 strn=
cat (v,
e->data + st=20
rlen (e->data) + 1,
../libexif-0.5.12/libexif/exif-entry.c:                 strn=
cat (v,
_("[None]"),=20
 sizeof (v) - 1);
../libexif-0.5.12/libexif/exif-entry.c:         strncat (v, =
" ", sizeof
(v) - 1)=20
;
../libexif-0.5.12/libexif/exif-entry.c:         strncat (v,
_("(Editor)"), sizeo=20
f (v) - 1);
../libexif-0.5.12/libexif/exif-entry.c:                 strn=
cat (v, c,
sizeof (v=20
));
../libexif-0.5.12/libexif/exif-entry.c:                 if (=
i < 3)
strncat (v, "=20
 ", sizeof (v));
../libexif-0.5.12/libexif/exif-entry.c:                     =
    strncat
(v, ", "=20
, sizeof (v));
../libexif-0.5.12/libexif/exif-entry.c:                     =
    strncat
(v, b, s=20
izeof (v));
../libexif-0.5.12/libexif/exif-entry.c:                     =
    strncat
(v, ", "=20
, sizeof (v));
../libexif-0.5.12/libexif/exif-entry.c:                     =
    strncat
(v, b, s=20
izeof (v));
../libexif-0.5.12/libexif/exif-entry.c:                     =
    strncat
(v, ", "=20
, sizeof (v));
../libexif-0.5.12/libexif/exif-entry.c:                     =
    strncat
(v, b, s=20
izeof (v));
../libexif-0.5.12/libexif/exif-entry.c:                     =
    strncat
(v, ", "=20
, sizeof (v));
../libexif-0.5.12/libexif/exif-entry.c:                     =
    strncat
(v, b, s=20
izeof (v));
../libexif-0.5.12/libexif/exif-entry.c:                     =
    strncat
(v, ", "=20
, sizeof (v));
../libexif-0.5.12/libexif/exif-entry.c:                     =
    strncat
(v, b, s=20
izeof (v));
../libexif-0.5.12/libexif/exif-entry.c:                     =
    strncat
(v, ", "=20
, sizeof (v));
../libexif-0.5.12/libexif/exif-entry.c:                     =
    strncat
(v, b, s=20
izeof (v));
../libmnote-0.5.6/libmnote/olympus/mnote-olympus-entry.c:   =
          =20
strncat =20
(v, "/", sizeof (v));
../libmnote-0.5.6/libmnote/olympus/mnote-olympus-entry.c:   =
          =20
strncat =20
(v, buf, sizeof (v));
../libmnote-0.5.6/libmnote/olympus/mnote-olympus-entry.c:   =
          =20
strncat =20
(v, "/", sizeof (v));
../libmnote-0.5.6/libmnote/olympus/mnote-olympus-entry.c:   =
           =20
      s=20
trncat (v, _("left to right"), sizeof (v));
../libmnote-0.5.6/libmnote/olympus/mnote-olympus-entry.c:   =
           =20
      s=20
trncat (v, _("right to left"), sizeof (v));
../libmnote-0.5.6/libmnote/olympus/mnote-olympus-entry.c:   =
           =20
      s=20
trncat (v, _("bottom to top"), sizeof (v));
../libmnote-0.5.6/libmnote/olympus/mnote-olympus-entry.c:   =
           =20
      s=20
trncat (v, _("top to bottom"), sizeof (v));
../libmnote-0.5.6/libmnote/olympus/mnote-olympus-entry.c:   =
           =20
      s=20
trncat (v, buf, sizeof (v));


Also what about the probing in mnote_data_new_from_data and =
the byte
order :
actualy because the lib have only acess to makernote data it=
 is
imposible and i have to force it...


____________________________________________________________=
_________
MSN Messenger, nouvelle version ! Personnalisez vos messages=
, jouez en
ligne et communiquez en temps r=E9el par vid=E9o! http://ifr=
ance.com/_reloc/m