Re: [Libexif-devel] Changes to libexif-gtk for migration to gtk3

[Marcus M. <ma...@je...>]

On Mon, Apr 23, 2012 at 10:15:51AM +0100, Valere Monseur wrote:
> Hi,
> Did you managed to find someone to review the code changes ?
> Thanks
> Valère
> >________________________________
> >De : Dan Fandrich <da...@co...>
> >À : lib...@li... 
> >Envoyé le : Vendredi 20 janvier 2012 10h56
> >Objet : Re: [Libexif-devel] Changes to libexif-gtk for migration to gtk3
> >
> >On Thu, Jan 19, 2012 at 09:38:41AM +0000, Valere Monseur wrote:
> >> First of all, I wish you a happy new year 2012 (ok, it's almost end of Jan, but better late than never).
> >> Regarding the below request for code review of gtk changes, did you had the opportunity to ask the gphoto2 devs ?
> >
> >I did, but the best person to review it was ill at the time. I'll try someone
> >else if I don't get a response by next week. Thanks for your patience.

Hi,

While my arm is better these days and my workload allows a bit of review ...

Your changes look sensible in general.

The ifdef/else/endif mess looks ugly but is bearable I think.

As I have no knowledge of GTK I cannot really tell if the 80KB 
updates2.diff is good or not though.

I would however say its good in the end.

Ciao, Marcus