Re: [Libexif-devel] [libexif-cvs] libexif/libexif/pentax mnote-pentax-entry.c, 1.11, 1.12

[Hans U. N. <gp...@n-...>]

I'd like to express some doubts regarding this commit.

> Modified Files:
> 	mnote-pentax-entry.c 
> Log Message:
> Unified handling of unknown tag values, some messages were not translated
> 
> 
> Index: mnote-pentax-entry.c
> ===================================================================
> RCS file: /cvsroot/libexif/libexif/libexif/pentax/mnote-pentax-entry.c,v
> retrieving revision 1.11
> retrieving revision 1.12
> diff -u -p -d -r1.11 -r1.12
> --- mnote-pentax-entry.c	13 May 2007 19:21:47 -0000	1.11
> +++ mnote-pentax-entry.c	24 May 2007 06:47:14 -0000	1.12
> @@ -341,7 +341,7 @@ mnote_pentax_entry_get_value (MnotePenta
>  			/* search the tag */
>  			for (i = 0; (items[i].tag && items[i].tag != entry->tag); i++);
>  			if (!items[i].tag) {
> -			  	strncpy (val, "Internal error", maxlen);
> +			  	strncpy (val, _("Internal error"), maxlen);
>  			  	break;
>  			}

OK... so we have one of the worst error messages ever (because it does
not give ANY hint as to what may have been the cause), and one which
definitely needs developer attention to fix if a user sees it.

Does it make the user experience better if that kind of message is
translated? The language for discussions with the developers is mainly
English, and we don't have translators for bug fixing discussions :)

> @@ -350,7 +350,7 @@ mnote_pentax_entry_get_value (MnotePenta
>  			    (items[i].elem[j].index < vs); j++);
>  			if (items[i].elem[j].index != vs) {
>  				snprintf (val, maxlen,
> -					  "Internal error (unknown value %i)", vs);
> +					  _("Internal error (unknown value %i)"), vs);
>  				break;
>  			}
>  			strncpy (val, items[i].elem[j].string, maxlen);

OK, that is a little better. At least some hint.