Re: [Libexif-devel] Code cleanup

[Jan P. <pa...@pi...>]

Hi Joerg,

I've found two possible problems:

1)  Could you please beautify it a little bit? I mean all colons
immediately after the text or separated with one space
> +  {1,N_("Macro mode")},
> +  {4,N_(" / Flash mode : ")},
> +  {5,N_(" / Continuous drive mode : ")},
> +  {7,N_(" / Focus mode : ")},
> +  {10,N_(" / Image size : ")},
> +  {11,N_(" / Easy shooting mode : ")},
> +  {13,N_(" / Contrast : ")},
> +  {14,N_(" / Saturation : ")},
> +  {15,N_(" / Sharpness : ")},
> +  {16,N_(" / ISO : ")},
> +  {17,N_(" / Metering mode : ")},
> +  {19,N_(" / AF point selected: ")},
> +  {20,N_(" / Exposure mode: ")},
> +  {32,N_(" / Focus mode2: ")},

2) Looks like the middle line shouldn't be there?
> +  {16,18,N_("200")},
> +  {16,19,N_("300")},
> +  {16,19,N_("400")},

Beside these I see no problems.

 --- Jan

>
> I've done a little code cleanup in libexif/canon/mnote-canon-entry.c,
> which saves us another 180 lines. I don't want to check it in without a
> short review; so can you please do a short look-through and point me to
> problematic places?
>
> Joerg