[Libexif-devel] Re: [libexif-cvs] libexif/test test-mem.c,1.6,1.7

[Jan P. <pa...@pi...>]

Hi Lutz,

shouldn't "size[1] =3D ebs << 8;" be in fact
"size[1] =3D ebs >> 8;"? Perhaps some (unsigned char) typecasts
would also be nice to avoid compiler warnings.

Regards,
       -- Jan


> Update of /cvsroot/libexif/libexif/test
> In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv24021/test
>
> Modified Files:
> 	test-mem.c
> Log Message:
> 2005-03-09  Lutz Mueller <lu...@us...>
>
> 	* test/test-mem.c: Write size to loader to make the test work again.
>
>
> Index: test-mem.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS
> file: /cvsroot/libexif/libexif/test/test-mem.c,v
> retrieving revision 1.6
> retrieving revision 1.7
> diff -u -d -r1.6 -r1.7
> --- test-mem.c	31 Aug 2004 06:11:03 -0000	1.6
> +++ test-mem.c	9 Mar 2005 22:03:18 -0000	1.7
> @@ -32,7 +32,7 @@
>  {
>  	ExifData *ed;
>  	ExifEntry *e;
> -	unsigned char *eb;
> +	unsigned char *eb, size[2];
>  	unsigned int ebs;
>  	ExifLoader *loader;
>  	unsigned int i;
> @@ -66,6 +66,9 @@
>
>  	printf ("Writing %i byte(s) EXIF data to loader...\n", ebs);
>  	loader =3D exif_loader_new ();
> +	size[0] =3D ebs;
> +	size[1] =3D ebs << 8;
> +	exif_loader_write (loader, size, 2);
>  	for (i =3D 0; i < ebs && exif_loader_write (loader, eb + i, 1); i++);
> printf ("Wrote %i byte(s).\n", i);
>  	free (eb);
>
>
>
> -------------------------------------------------------
> SF email is sponsored by - The IT Product Guide
> Read honest & candid reviews on hundreds of IT Products from real users=
.
> Discover which products truly live up to the hype. Start reading now.
> http://ads.osdn.com/?ad_id=3D6595&alloc_id=3D14396&op=3Dclick
> _______________________________________________
> libexif-cvs mailing list
> lib...@li...
> https://lists.sourceforge.net/lists/listinfo/libexif-cvs