From: Antonio S. <sc...@te...> - 2004-04-22 20:30:19
|
Hi, Since I did not find the 0.6.9 tar I updated from CVS to compile it and= =20 here are some comments: 1) Would be very nice to have a function like: const char * exif_tag_get_name_index (unsigned int i, ExifTag *tag) { if (!ExifTagTable[i].name) return NULL; *tag =3D ExifTagTable[i].tag; return (ExifTagTable[i].name); } in "exif-tag.c". It allows me to scan over all the defined tags. 2) The file "exif-data.c" depends on the header file "jpeg-marker.h" that=20 it is in the pack, but outside the library folder. Why not to move this=20 header to the libexif folder? Also Open Watcom complained about it: libjpeg/jpeg-marker.h(27): Error! E1115: Incomplete enum declaration I change to the old version. 3) I created a simple "_stdint.h" by hand from Cygwin "stdint.h", all the=20 platforms I use the types used have fixed sizes. The "_stdint.h" is a good= =20 solution for the library users. 4) I still use the same "config.h" that I mention before: #define GETTEXT_PACKAGE "libexif-9" #ifdef WIN32 #define snprintf _snprintf #endif 5) I have to edit the function exif_entry_initialize from "exif-entry.c".=20 There are lots of uninitialized tags. I simply replace the function with my= =20 version. Then saving exif tags in jpeg came back to normal. That=B4s it. This is working in Windows (gcc3, Mingw3, OpenWatcom, VC6= and=20 VC7) and in UNIX (Linux, IRIX, AIX and SunOS). libexif is used internally= =20 by an also free library called IM. I updated the library this month. You=20 may find it at: http://www.tecgraf.puc-rio.br/im Issues 1 and 2 are not a big deal, but I would appreciate if you guys=20 can think about issue 5. I can send you my version of the function attached. Best, scuri |