Re: [Libexif-devel] Re: assorted patches (mostly rpm build related)

[Daniel R. <no...@me...>]

On Fri, 2003-01-03 at 15:10, Arnaud Launay wrote:
> Hello,
> 
> Le Wed, Jan 01, 2003 at 09:13:43PM +0100, Daniel Resare a écrit:
> > Since the latest released versions doesn't compile i decided to
> > try out HEAD cvs and to my great joy it worked out nicely.
> 
> This is disturbing. What's wrong with released versions ? We need
> to know...
> 

libexif-0.5.8 as distributed from sf.net does not include the header
file libexif/exif-note.h (as it was broken out into libmnote) that is
needed by exif-0.5.tar.gz also distributed from sf.net

IMHO the release of libexif-0.5.8.tar.gz should have been delayed until
exif was updated to match the new library, and libmnote was ready for
release.

> > A few details:
> > - the exif/exif directory in cvs should really be removed
> > manually so that new users doesn't get confused when they
> > forget to check out with -P
> 
> I don't get that. Could you be more specific ?
> 

In cvs you don't remove directory but instead there is a convention that
empty directories should be treated like they weren't there. To achieve
that 'cvs update' and 'cvs checkout' has the -P flag, that removes all
empty directories in the working tree.

If you check out the exif package from cvs and skip using the -P flag,
your compile will fail as there is an empty directory named
/cvsroot/exif/exif/exif, accidentally also the name of the binary that
is to be created.

So when i run "cvs -z3
-d:pserver:ano...@cv...:/cvsroot/libexif co exif" (cut
and paste from sf.net project page)

and then "./autogen.sh; ./configure; make" the build fails with the
message:

rm: cannot remove `exif': Is a directory
make[2]: *** [exif] Error 1
make[2]: Leaving directory `/home/noa/slask/exif/exif'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/noa/slask/exif'
make: *** [all] Error 2

There are some solutions to this problem:

1) run 'rm -rf exif/exif' before make
2) Checkout with the -P option after 'co'
3) Use an alternate build directory
4) Log in to the cvs server and remove /cvsroot/libexif/exif/exif/exif

> > - typo in exif.1 (see attachment 0)
> 
> Commited. BTW, I also added a fix, IFD was written IDF :)

oops. That a quite high typo percentage (two chars wrong out of four
added) *smile*

> 
> > gettextize edits configure.in and Makefile.am when it is called
> > through ./autogen.sh. I see the point in having intl/ symlinked
> > in from the current version, but the changing of the mentioned
> > files above makes sending in patches against cvs difficult, so
> > I think that those changes should be applied to cvs HEAD.
> 
> No. We support gettextize from 0.10.40 to the latest ones, and
> unfortunately they don't act the same way, one modifies the files
> under every circumstances, another one doesn't, and sometimes
> rerunning gettextize just adds the files twice (!). So the
> current solution is the best, as we don't depend on a specific
> version of gettext. That way, everybody could use the cvs.
> 

Oki, if the current solution is well thought out then we should use it.
Having the added lines in Makefile.am and configure.in is only a minor
annoyance anyway.

cheers!
/noa