[libexif-cvs] libexif-testsuite/tests check-readwrite-identity.sh, NONE, 1.1 Makefile.am, 1.23, 1.24

[Dan F. <dfa...@us...>]

Update of /cvsroot/libexif/libexif-testsuite/tests
In directory ddv4jf1.ch3.sourceforge.com:/tmp/cvs-serv22972/tests

Modified Files:
	Makefile.am 
Added Files:
	check-readwrite-identity.sh 
Log Message:
Added check-readwrite-identity.sh test that passes each JPEG image
through a read/write/read pass to ensure that the final written tags equal
the originals


--- NEW FILE: check-readwrite-identity.sh ---
#!/bin/sh
# Read then write (unmodified) each image through exif.
# Check that the written image contains the same data as the original.

. check-vars.sh

tmpfile="./output.tmp"
tmpfile2="./output2.tmp"
tmpimg="./readwrite.out.jpg"

# Display ok or FAILED depending on the result code
check_result () {
	s="$?"
	if test "$s" -eq 0; then
		echo " ok."
	else
		echo " FAILED (${s})."
		errors=$(expr $errors + 1)
		if [ -z "$1" ] ; then
			true cat "$tmpfile"
		else
			true cat "$1"
		fi
		continue
	fi
}

# Put exif output into canonical form by removing lines that could change
canonicalize () {
	# Remove the MakerNote tag (0x927c) as well. This really shouldn't be
	# necessary, but it seems that there are some problems with
	# several MakerNotes types so they aren't completely identical to
	# the originals right now.
	sed -i  -e '/^EXIF tags in /d' \
		-e '/^0x927c/d' \
	  "$1"
}

echo Testing "$EXIFEXE"

errors=0
total=0
total_img=0

for img in $ALLFILES
do
	test -f "$img" || continue

	if noexiftags "$img" ; then
		continue # skip image
	fi

	total_img=$(expr $total_img + 1)
	echo \#${total_img}

	# Create a copy of the image that has been processed by exif
	# Force this by attempting deleting a nonexistent tag
	echo -n "Copying image \`${img}'..."
	"$EXIFEXE" --remove --tag=0xbeef --output="${tmpimg}" "${img}" > "$tmpfile" 2>&1
	check_result

	# Listing original EXIF info
	echo -n "Listing EXIF info..."
	# Run this in the C language locale so the messages are known
	env LANG=C LANGUAGE=C "$EXIFEXE" --ids "${img}" > "$tmpfile" 2>&1
	check_result

	# Listing copied EXIF info
	echo -n "Listing EXIF info..."
	# Run this in the C language locale so the messages are known
	env LANG=C LANGUAGE=C "$EXIFEXE" --ids "${tmpimg}" > "$tmpfile2" 2>&1
	check_result $tmpfile2

	canonicalize "$tmpfile"
	canonicalize "$tmpfile2"
	echo -n "Comparing before and after..."
	"$DIFFEXE" "$tmpfile" "$tmpfile2"
	check_result

	# Listing original MakerNote info
	echo -n "Listing MakerNote info..."
	# Run this in the C language locale so the messages are known
	env LANG=C LANGUAGE=C "$EXIFEXE" --ids --show-mnote "${img}" > "$tmpfile" 2>&1
	check_result

	# Listing copied MakerNote info
	echo -n "Listing MakerNote info..."
	# Run this in the C language locale so the messages are known
	env LANG=C LANGUAGE=C "$EXIFEXE" --ids --show-mnote "${tmpimg}" > "$tmpfile2" 2>&1
	check_result $tmpfile2

	canonicalize "$tmpfile"
	canonicalize "$tmpfile2"
	echo -n "Comparing before and after..."
	"$DIFFEXE" "$tmpfile" "$tmpfile2"
	check_result

done

rm "$tmpfile"
rm "$tmpfile2"
rm "$tmpimg"

self="$(basename "$0")"
echo "$self: Checked $total_img images."
echo "$self: $errors checks failed."
test "$errors" -eq 0

Index: Makefile.am
===================================================================
RCS file: /cvsroot/libexif/libexif-testsuite/tests/Makefile.am,v
retrieving revision 1.23
retrieving revision 1.24
diff -u -p -d -r1.23 -r1.24
--- Makefile.am	22 Jan 2009 07:47:50 -0000	1.23
+++ Makefile.am	19 Sep 2009 05:23:45 -0000	1.24
@@ -9,6 +9,7 @@ SUBDIRS = images
 EXTRA_DIST = \
 	check-exif-executable.sh \
 	check-general-images.sh \
+	check-readwrite-identity.sh \
 	check-no-unknown-tags.sh \
 	check-all-mandatory-tags.sh \
 	check-994706.sh check-994706.b.patch \
@@ -22,11 +23,14 @@ if HAVE_EXIF_CLI
 check_SCRIPTS = \
 	check-exif-executable.sh \
 	check-994706.sh \
-	check-1054321.sh check-1054322.sh check-1054323.sh \
+	check-1054321.sh \
+	check-1054322.sh \
+	check-1054323.sh \
 	check-1169170.sh
 
-# This check script may take a little long - but it is invaluable. :)
+# These check scripts may take a little long - but are invaluable. :)
 check_SCRIPTS += check-general-images.sh \
+	check-readwrite-identity.sh \
 	check-no-unknown-tags.sh \
 	check-all-mandatory-tags.sh