Re: [Libexif-devel] [libexif-cvs] libexif/libexif exif-entry.c, 1.128, 1.129 exif-entry.h, 1.21, 1.22

[Marcus M. <ma...@je...>]

On Sun, Feb 01, 2009 at 03:05:13PM +0100, Jan Patera wrote:
> Dan,
> 
> unfortunately this doesn't compile with every compiler.
> For example MSVC at least versions 6 through 8 don't support this way of
> inlining in C (it is OK in C++).
> For 'C', the right syntax there is
> 
> static __declspec(inline) ExifShort
> 
> My suggestion is to create a macro INLINE and use it instead.
> FYI: when MSVC is used, macro _MSC_VER is defined.

Run AC_C_INLINE() in the autoconf script, it will define "inline"
to empty on compilers that dont know it.
 
> > file: /cvsroot/libexif/libexif/libexif/exif-entry.c,v
> > +static inline ExifShort
> > +exif_get_short_convert (const unsigned char *buf, ExifFormat format,
> > +			ExifByteOrder order)

And inline is not really necessary, gcc will just decide on its own
whether to inline or not.

Ciao, Marcus