Re: [Libexif-devel] [libexif-cvs] libexif/libexif exif-content.c, 1.22, 1.23 exif-data.c, 1.107, 1.108

[Jan P. <pa...@pi...>]

Lutz,

to be absolutely correct, you should not update *ds if the realloc
fails. Then the code can easily touch memory beyond allocated area...
(IMHO harder to find than eventually touching NULL.)
Similarly in *most* your fixes (I wouldn't bother *much* when actually
decreasing the allocated size).

> file: /cvsroot/libexif/libexif/libexif/exif-data.c,v
>  		if (s & 1)
>  			(*ds)++;
> -		*d = exif_mem_realloc (data->priv->mem, *d, *ds);
> -		if (!*d) {
> +		t = exif_mem_realloc (data->priv->mem, *d, *ds);
> +		if (!t) {
>  			EXIF_LOG_NO_MEMORY (data->priv->log, "ExifData", *ds);
>  		  	return;
>  		}
> +		*d = t;

 --- Jan